build: fix: remove error output #4155

while git not found in path, error is output to console.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b1f0be0a05aca81e564139472206dee72410976e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

What OS's/shells which command produces output when a command is not found? I've just tried on linux and the output is empty in that case.

i build it on win7 with mingw & msys, if i just type make, it will be a little annoying . but if i use PATH=$PATH:/c/Git/bin make, it will not output error.

so, i do think it is not serious patch.

2014-05-09 17:39 GMT+08:00 Wladimir J. van der Laan < notifications@github.com>:

What OS's which command produces output when a command is not found? I've just tried on linux and the output is empty in that case.

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/4155#issuecomment-42649050 .

Harry Wu

Software Engineer.

TVU networks

1279, Zhongshan Road West, Building 6, Suite 732, Shanghai, P.R.C

harrywu@tvunetworks.com

Office: +86.21.3209.5581#262

Fax: +86.21.3209.5515

Making every transmission a success

www.tvupack.com

facebook.com/TVUPack | twitter.com/tvupack | blog.tvupack.com

Interesting. Well if that is the case I tend to ACK this. What is the terminal output if you type:

which git

And it can't find git?

Yes, before outputing: CXX version.o console will print this: which: git: unknown command

together with previous util.o, terminal is like this: CXX util.o which: git: unknown command CXX version.o

i track the building script, and found that it is because the share/genbuild.sh

i build bitcoind-qt on win7 successfully, and portted it to eclipse ide.

BTW, makensis will complains that @abs_top_srcdir@ in share/setup.nsi.inafter configure, if @abs_top_srcdir@is mapped to an unix_path, such as /e/workspace/bitcoin-src, may be i will use it in linux and do a cross compile, or use a msys portted makensis.exe to make a cool install package. and now it will be ok, because before make deploy, i fix the path manually to windows path to these resources files( bmp,icons). :)

2014-05-09 18:01 GMT+08:00 Wladimir J. van der Laan < notifications@github.com>:

Interesting. Well if that is the case. What is the terminal output if you type:

which git

And it can't find git?

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/4155#issuecomment-42650695 .

Harry Wu

Software Engineer.

TVU networks

1279, Zhongshan Road West, Building 6, Suite 732, Shanghai, P.R.C

harrywu@tvunetworks.com

Office: +86.21.3209.5581#262

Fax: +86.21.3209.5515

Making every transmission a success

www.tvupack.com

facebook.com/TVUPack | twitter.com/tvupack | blog.tvupack.com

ACK