Most of the base58 code isn't templated, and certainly doesn't need any inlining for performance. Move most of it to base58.cpp.
Move base58.h implementation code to base58.cpp #4165
pull sipa wants to merge 1 commits into bitcoin:master from sipa:base58cpp changing 3 files +219 −227-
sipa commented at 9:51 PM on May 9, 2014: member
-
Move base58.h implementation code to base58.cpp f6b7c644c9
-
BitcoinPullTester commented at 11:03 PM on May 9, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f6b7c644c998799c10704be4a5b42d9cacc8a746 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:09 AM on May 10, 2014: member
ACK code changes, haven't tested.
- laanwj merged this on May 12, 2014
- laanwj closed this on May 12, 2014
- laanwj referenced this in commit 68d5fb3cb3 on May 12, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors