Fix addnode "onetry": Connect with OpenNetworkConnection #4166

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz2 changing 3 files +2 −4

cozz commented at 10:48 PM on May 9, 2014: contributor

Nodes added with "onetry" do not get deleted from memory when they get disconnected. This causes FinalizeNode and so some clean up code to not get called.

The reason is for onetry nodes fNetworkNode is false, because we connect them with ConnectNode. The nodes get disconnected but still stay in the disconnected pool forever.

So use OpenNetworkConnection instead of ConnectNode. The only difference now is that fNetworkNode is true.
Fix addnode "onetry": Connect with OpenNetworkConnection b641c9cd21
sipa commented at 10:58 PM on May 9, 2014: member

Untested ACK.
BitcoinPullTester commented at 12:04 AM on May 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b641c9cd217f7789726bb25ab87cd35e2e5fcaad for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:07 AM on May 10, 2014: member

Won't this also bypass the outbound connections limit?
cozz commented at 9:30 AM on May 10, 2014: contributor

@laanwj yes, but it did also before. This is at least good for testing. Does this cause any problems?

OpenNetworkConnection calls ConnecNode. So, as I said, the only difference is that the connection has fNetworkNode set to true now.
laanwj commented at 9:32 AM on May 10, 2014: member

Sure, it's fine with me if that was the behaviour before as well.
laanwj merged this on May 23, 2014
laanwj closed this on May 23, 2014
laanwj referenced this in commit 1b7bcba1c1 on May 23, 2014
DrahtBot locked this on Sep 8, 2021

Contributors