Fix incorrect checkpoint data for testnet3 #4184

No description provided.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/122549f6dee5f4d4daf7091d6302c38ba13ffb01 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

What steps did you take to get this information? How to verify this?

getblock 000000002a936ca763904c3c35fce2f3556c559c0214345d31b1bcebf76acb70 (checkpoint 546) shows time of "1337966069".

Regarding the total number of TXs, I wrote code to check:

package main

import (
        "fmt"
        "github.com/conformal/btcrpcclient"
)

var (
        client *btcrpcclient.Client
)

func CountTxs(count int64) (uint64, error) {
        totalTxs := uint64(0)
        for i := int64(0); i <= count; i++ {
                sha, err := client.GetBlockHash(i)
                if err != nil {
                        return 0, err
                }
                blk, err := client.GetBlock(sha)
                if err != nil {
                        return 0, err
                }
                txs := len(blk.Transactions())
                totalTxs += uint64(txs)
        }
        return totalTxs, nil
}

func main() {
    var err error
        cfg := btcrpcclient.ConnConfig{
                Host:         "127.0.0.1:18332",  // testnet
                User:         "dajohi",
                Pass:         "mypass",
                HttpPostMode: true,
                DisableTLS:   true,
        }
        client, err = btcrpcclient.New(&cfg, nil)
        if err != nil {
                fmt.Printf("%v\n", err)
                return
        }


        total, err := CountTxs(546)
        if err != nil {
                fmt.Printf("CountTxs error: %v\n", err)
                return
        }
        fmt.Printf("total txs: %d\n", total)
}

<pre> $ go run txcount.go total txs: 1488 </pre>

ACK

from __future__ import division,print_function
from bitcoinrpc.authproxy import AuthServiceProxy, JSONRPCException
import sys

tgt = sys.argv[1]
count_to = int(sys.argv[2])
proxy = AuthServiceProxy(tgt)
total = 0

for block in range(count_to+1):
    blockhash = proxy.getblockhash(block)
    info = proxy.getblock(blockhash)
    total += len(info['tx'])

print('Total transactions:', total)
print('Time of last block:', info['time'])

$ python count_transactions.py http://bitcoinrpc:AbmPZxYieDW6DosvA8S3VjCA7zb3mi49h4HqzdDJXvQ@127.0.0.1:18332 546
Total transactions: 1488
Time of last block: 1337966069