Doc: Always use absolute paths #4195

pull kostaz wants to merge 1 commits into bitcoin:master from kostaz:doc_absolute_paths changing 1 files +10 −0

kostaz commented at 10:47 AM on May 19, 2014: contributor

No description provided.
Doc: Always use absolute paths f701da8f70
in doc/build-unix.md:None in 8f1f47aed6 outdated
```
   1 | @@ -2,6 +2,11 @@ UNIX BUILD NOTES
   2 |  ====================
   3 |  Some notes on how to build Bitcoin in Unix. 
   4 |  
   5 | +Note
   6 | +---------------------
   7 | +Always use absolute paths to configure and compile bitcoin
   8 | +and the dependencies.
```
laanwj commented at 7:48 AM on May 20, 2014:

This is could be a bit more specific, maybe: 'always pass absolute paths to configure when specifying the path of dependency libraries'
kostaz commented at 3:20 AM on May 21, 2014:

Update the pull request with the below:

commit c441712baf54189403919edf4731e04a7f43daaf Author: Kosta Zertsekel zertsekel@gmail.com Date: Mon May 19 13:42:57 2014 +0300

Doc: Always use absolute paths

diff --git a/doc/build-unix.md b/doc/build-unix.md index ab5fbad..d31191d 100644 --- a/doc/build-unix.md +++ b/doc/build-unix.md @@ -2,6 +2,15 @@ UNIX BUILD NOTES

Some notes on how to build Bitcoin in Unix.

+Note+---------------------+Always use absolute paths to configure and compile bitcoin and the dependencies,+for example, when specifying the the path of the dependency:++../dist/configure --enable-cxx --disable-shared --with-pic --prefix=$BDB_PREFIX+Here BDB_PREFIX must absolute path - it is defined using $(pwd) which ensures+the usage of the absolute path.+ To Build

Kosta

On Tue, May 20, 2014 at 10:48 AM, Wladimir J. van der Laan < notifications@github.com> wrote:

In doc/build-unix.md:

@@ -2,6 +2,11 @@ UNIX BUILD NOTES

Some notes on how to build Bitcoin in Unix.

+Note +--------------------- +Always use absolute paths to configure and compile bitcoin +and the dependencies.

This is could be a bit more specific, maybe: 'always pass absolute paths to configure when specifying the path of dependency libraries'

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/4195/files#r12831190 .
in doc/build-unix.md:None in c441712baf outdated
```
   1 | @@ -2,6 +2,15 @@ UNIX BUILD NOTES
   2 |  ====================
   3 |  Some notes on how to build Bitcoin in Unix. 
   4 |  
   5 | +Note
   6 | +---------------------
   7 | +Always use absolute paths to configure and compile bitcoin and the dependencies,
   8 | +for example, when specifying the the path of the dependency:
   9 | +
  10 | +../dist/configure --enable-cxx --disable-shared --with-pic --prefix=$BDB_PREFIX
```
laanwj commented at 6:57 AM on May 21, 2014:

Code fragment: would be nice to delimit with

../dist/configure --enable-cxx --disable-shared --with-pic --prefix=$BDB_PREFIX

To make it appear highlighted and indented
kostaz commented at 8:02 AM on May 21, 2014:

Fixed.

Sorry - I'm kind of new to the markdown stuff. Now checked the preview here: http://tmpvar.com/markdown.html. Also, the patch itself is attached. Strangely, I don't see the must-have tab (\t) before the example line in github pull request.

Thanks, --- Kosta

On Wed, May 21, 2014 at 9:57 AM, Wladimir J. van der Laan < notifications@github.com> wrote:

In doc/build-unix.md:

@@ -2,6 +2,15 @@ UNIX BUILD NOTES

Some notes on how to build Bitcoin in Unix.

+Note +--------------------- +Always use absolute paths to configure and compile bitcoin and the dependencies, +for example, when specifying the the path of the dependency: + +../dist/configure --enable-cxx --disable-shared --with-pic --prefix=$BDB_PREFIX

Code fragment: would be nice to delimit with

../dist/configure --enable-cxx --disable-shared --with-pic --prefix=$BDB_PREFIX

To make it appear highlighted

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/4195/files#r12883014 .
BitcoinPullTester commented at 8:26 AM on May 21, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f701da8f707726e4097e17234cdd7b55255c1077 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:37 AM on May 21, 2014: member

It's best to use github's rendered output to see what the result will be. From what I've seen, none of the markdown tools really understands github's dialect ("github flavored markdown") well especially the code highlighting features.
laanwj merged this on May 28, 2014
laanwj closed this on May 28, 2014
laanwj referenced this in commit cd19892d98 on May 28, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

kostaz

laanwj

BitcoinPullTester

Doc: Always use absolute paths #4195

diff --git a/doc/build-unix.md b/doc/build-unix.md index ab5fbad..d31191d 100644 --- a/doc/build-unix.md +++ b/doc/build-unix.md @@ -2,6 +2,15 @@ UNIX BUILD NOTES

@@ -2,6 +2,11 @@ UNIX BUILD NOTES

@@ -2,6 +2,15 @@ UNIX BUILD NOTES