Add missing LOCK(cs_main) #4204

pull sipa wants to merge 1 commits into bitcoin:master from sipa:lock changing 1 files +4 −1
  1. sipa commented at 7:46 pm on May 20, 2014: member
  2. Add missing LOCK(cs_main) 305ccaa275
  3. BitcoinPullTester commented at 8:02 pm on May 20, 2014: none
    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/305ccaa27551efa33fcaf637e76310654738f428 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
  4. in src/main.cpp: in 305ccaa275
    3487@@ -3488,7 +3488,10 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv)
    3488         return true;
    3489     }
    3490 
    3491-    State(pfrom->GetId())->nLastBlockProcess = GetTimeMicros();
    3492+    {
    3493+        LOCK(cs_main);
    3494+        State(pfrom->GetId())->nLastBlockProcess = GetTimeMicros();
    


    laanwj commented at 6:49 am on May 21, 2014:
    ACK. mapNodeState requires cs_main as well.
  5. laanwj added this to the milestone 0.9.2 on May 21, 2014
  6. laanwj merged this on May 21, 2014
  7. laanwj closed this on May 21, 2014

  8. laanwj referenced this in commit 8cd900711c on May 21, 2014
  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-13 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me