Upgrade gitian windows to qt-5.2.1 #4205

pull wtogami wants to merge 1 commits into bitcoin:master from wtogami:windows_qt521 changing 3 files +9 −9

wtogami commented at 11:34 PM on May 20, 2014: contributor

This PR corresponds with the qt-5.2.1 for gitian OS X in #4185.

Please verify that your build matches this.

27d005789086973fe3cad1a0fd840fa0596725e7503161f5a3322094e0b86925  qt-win32-5.2.1-gitian-r3.zip
4b824fde7345e13f69d20d3298c80ee100b2c2a9499ae1e4c6ac73f28f046bb8  qt-win64-5.2.1-gitian-r3.zip

Upgrade gitian windows to qt-5.2.1 b3900899df
BitcoinPullTester commented at 11:52 PM on May 20, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b3900899df3ec1fb32e24742101e10f6cc1af9cd for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

in doc/release-process.md:None in b3900899df

  45 | @@ -46,7 +46,7 @@ Release Process
  46 |  	wget 'https://downloads.sourceforge.net/project/boost/boost/1.55.0/boost_1_55_0.tar.bz2'
  47 |  	wget 'https://svn.boost.org/trac/boost/raw-attachment/ticket/7262/boost-mingw.patch' -O \ 
  48 |  	     boost-mingw-gas-cross-compile-2013-03-03.patch
  49 | -	wget 'https://download.qt-project.org/official_releases/qt/5.2/5.2.0/single/qt-everywhere-opensource-src-5.2.0.tar.gz'
  50 | +	wget 'https://download.qt-project.org/official_releases/qt/5.2/5.2.1/single/qt-everywhere-opensource-src-5.2.1.tar.gz'
  51 |  	wget 'https://download.qt-project.org/archive/qt/4.6/qt-everywhere-opensource-src-4.6.4.tar.gz'

laanwj commented at 7:27 AM on May 21, 2014:

Please update the expected SHA256 hash of the intermediate deps in doc/release-process.md as well

wtogami commented at 8:23 AM on May 21, 2014:

No. That's done in the OS X PR in #4185.

laanwj commented at 8:38 AM on May 21, 2014:

No, it is not! How can it? It would be specific to the windows depencencies.

Diapolo commented at 7:33 AM on May 21, 2014: none

There was recently Qt 5.3.0 released, perhaps we should use that instead ;)?
laanwj commented at 7:56 AM on May 21, 2014: member

@Diapolo I think that makes sense. To me there seems to be no pressing reason to upgrade to 5.2.1 for windows, so if we are going to do all the testing and such that is involved with upgrading anyway, let's go for the highest available release.
wtogami commented at 8:25 AM on May 21, 2014: contributor

@laanwj We did extensive testing of 5.2.0 and 5.2.1 to the point of not being concerned about it. Yes there is no pressing need to upgrade Windows except it was easy and it uses the same source as OSX.

Do you want to upgrade OS X to 5.3.0 too?
laanwj commented at 8:35 AM on May 21, 2014: member

Yes eventually I want to upgrade OSX to 5.3.0 as well, but not now. Let's test what we have now for a while and not make last-minute changes all the time.

I think targeting Qt 5.3 for 0.10 makes sense.

Windows is a different story. If we're going to upgrade the dep, let's go straight to 5.3.0. In both cases we need to test first, there is no reason to prefer 5.2.1.
wtogami commented at 10:14 AM on May 21, 2014: contributor

Closing for now, no real reason to upgrade to qt-5.2.1 at the last minute when the well-tested qt-5.2.0 has no known problems.
wtogami closed this on May 21, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4185 gitian: Add OSX build descriptors