Make links on 'About Bitcoin Core' into clickable #4211

pull tkembo wants to merge 2 commits into bitcoin:master from tkembo:master changing 2 files +213 −19

tkembo commented at 11:23 AM on May 22, 2014: none

Made the following links clickable: http://www.opensource.org/licenses/mit-license.php http://www.openssl.org/ eay@cryptsoft.com

Make links on 'About Bitcoin Core' into clickable

Made the following links clickable:
http://www.opensource.org/licenses/mit-license.php
http://www.openssl.org/
eay@cryptsoft.com

13665fa694

Replaced label with text browser on About Bitcoin Core Screen
So that the links on the About screen can be clickable
a48369dce2

in src/qt/forms/aboutdialog.ui:None in 13665fa694 outdated

 101 | @@ -102,7 +102,7 @@
 102 |        </widget>
 103 |       </item>
 104 |       <item>
 105 | -      <widget class="QLabel" name="label_2">
 106 | +      <widget class="QLabel::setOpenExternalLinks(bool)" name="label_2">

laanwj commented at 11:37 AM on May 22, 2014:

I don't understand this line. This changes the class of the widget to QLabel::setOpenExternalLinks(bool). What does that do?

in src/qt/forms/aboutdialog.ui.autosave:None in a48369dce2
```
   0 | @@ -0,0 +1,199 @@
   1 | +<?xml version="1.0" encoding="UTF-8"?>
```
Diapolo commented at 2:02 PM on May 22, 2014:

That file doesn't belong in here...
Diapolo commented at 2:03 PM on May 22, 2014: none

Not sure this is any good in the current implementation, because that text with all it's fancy HTML stuff will make translators (and me) scream I guess :-D.

The more I think about it... NACK!
tkembo commented at 2:20 PM on May 22, 2014: none

You're right. I hadn't considered that
tkembo closed this on May 22, 2014
BitcoinPullTester commented at 2:36 PM on May 22, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a48369dce2d47b5a0ae5795715ad874c7e71f60d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:21 AM on May 23, 2014: member

@Diapolo Hm yes, thinking about it, clickable links in translatable text could be a way for translators to introduce spam/links to malware. This would need some construction with %1 and .args as in the example address case (#4208)...

Although I like the idea here, it's too much work to do this safely and sanely.

BTW: So links in qt textareas are not clickable by default unless a specific attribute is set on the text area? That's great.
DrahtBot locked this on Sep 8, 2021

Contributors