Make links on 'About Bitcoin Core' into clickable #4213

tkembo commented at 2:51 PM on May 22, 2014: none

I have now replaced the html property with a text property. This removed unnecessary html and makes life easier for translators @Diapolo :). The idea is to make the following links clickable: http://www.opensource.org/licenses/mit-license.php http://www.openssl.org/ eay@cryptsoft.com

in src/qt/forms/aboutdialog.ui:None in f60b5a935c outdated

 109 | @@ -110,9 +110,12 @@
 110 |          <string>
 111 |  This is experimental software.
 112 |  
 113 | -Distributed under the MIT/X11 software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php.
 114 | +Distributed under the MIT/X11 software license, see the accompanying file COPYING or &lt;a href=&quot;http://www.opensource.org/licenses/mit-license.php&quot;&gt;http://www.opensource.org/licenses/mit-license.php&lt;/a&gt;.

Diapolo commented at 6:15 AM on May 23, 2014:

That's better, but still contains a lot of translation noise IMHO :-/.

tkembo commented at 6:19 AM on May 23, 2014:

I wouldn't call it a lot of noise and I think it's a necessary evil. The noise is only just before or just after a hyperlinks and those need no translation. But that's just my opinion.

Diapolo commented at 8:30 PM on May 28, 2014:

IMHO this text could also be set just in the aboutdialog constructor (in utilitydialog.cpp) and we could then use ui->label_2->setText("Blabla %1... dadada %2... etc... %3").arg("http://www.foo.bar").arg("http://www.foo2.bar").arg("http://www.foo3.bar").

in src/qt/forms/aboutdialog.ui:None in f60b5a935c outdated

   5 | @@ -6,8 +6,8 @@
   6 |     <rect>
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 | -    <width>593</width>
  10 | -    <height>319</height>
  11 | +    <width>602</width>
  12 | +    <height>420</height>

laanwj commented at 4:58 PM on May 28, 2014:

I don't think the size of the window needs to change?

tkembo commented at 5:10 PM on May 28, 2014:

I have fixed that. Thanks @laanwj for pointing that out

laanwj commented at 4:59 PM on May 28, 2014: member

Looks good to me, ACK after changing back the size and squashing the three commits into one commit.

tkembo commented at 5:37 PM on May 28, 2014: none

OK. I'll wait a while to see if there are any other suggestions before squashing the 3 commits into one

Diapolo commented at 8:31 PM on May 28, 2014: none

I'd also suggest to use https://www.openssl.org over the http link.

Make links on 'About Bitcoin Core' into clickable (squashed 5 comits into one)

Made the following links clickable:
http://www.opensource.org/licenses/mit-license.php
http://www.openssl.org/
eay@cryptsoft.com

(Squashed commits into one commit as suggested by @laanwj)

Replaced label with text browser on About Bitcoin Core Screen

So that the links on the About screen can be clickable

Replaced html property with text property

I have now removed unnecessary html so this should make life easier for
translators and you @Diapolo :). What do you think?

The size of the window needs to change

The size of the window needs to change when you make links clickable.
Thanks  for pointing that out @laanwj

Using the https://www.openssl.org over the http link

Using the https://www.openssl.org over the http link as suggested by
@Diapolo

516053c349

tkembo commented at 7:32 AM on June 2, 2014: none

OK. I've just squashed the commits into one commit and changed the http://www.openssl.org to https://www.openssl.org

BitcoinPullTester commented at 8:20 AM on June 2, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/516053c349f8abde09597962f4dd3958a2825177 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj merged this on Jun 2, 2014

laanwj closed this on Jun 2, 2014

laanwj referenced this in commit 51615e1693 on Jun 2, 2014

DrahtBot locked this on Sep 8, 2021