release: Bump the OSX SDK to 10.7 for gitian builds #4229

This fixes the display on Retina Macbooks. It also moves us away from depending on the ancient XCode3 sdk.

The only downside is that the 10.7 sdk is not easily separated from the rest of the dmg: https://developer.apple.com/downloads/download.action?path=Developer_Tools/xcode_4.6.3/xcode4630916281a.dmg

That means, unfortunately, that a Mac is required to create a tarball from the MacOSX10.7.sdk directory in that dmg, which will likely not be a deterministic process. I don't believe that should affect the final output, though.

I would be very grateful if someone managed to crack open the dmg and extract the SDK from Linux, but none of the usual tools work on this one.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2869b1349b2cce3ac8fa8a39e0df65e4201c438a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Seems someone uploaded the MacOSX 10.7 SDK files to github more than a year ago:

https://github.com/JuliaEichler/Mac_OSX_SDKs/tree/master/MacOSX10.7.sdk (commit ebff7b92e0507032d1cfc9e39d91375f6044090e)

I guess it's of somewhat questionable legality, but if we can verify them to match with the 'True' files as extracted from a Mac I suppose it's an option for gitian builders until we have a Linux tool for extracting the stuff...

A quick diff shows that they don't match up exactly, unfortunately. But I'm sure it's enough to test the process if you don't have an osx machine around to extract with.

Build successful for me

Using SDK from Xcode 4.5.2

Intermediate:

1ff646a8b529c4de96993d14d2e0c1ddeea180108afcd6714052359733dca9ea  osx-depends-qt-5.2.1-r3.tar.gz
23764c3fc29240d67a2e8f24c59ab988162450af21c5d226a974a0a69570629e  osx-depends-r3.tar.gz
512bc0622c883e2e0f4cbc3fedfd8c2402d06c004ce6fb32303cc2a6f405b6df  osx-native-depends-r3.tar.gz

Outputs (built from tag 7a419a6):

850b8e1ad5699f009b942b588378b3e5b5f1ad9a67b256bd53af63809281fa21  Bitcoin-Qt.dmg
1fab518b933198078ed4b04f32049a0a55226430b662a1d9a839cf1eb4805c76  bitcoin-res.yml

Using SDK from github mentioned above

Intermediate:

512bc0622c883e2e0f4cbc3fedfd8c2402d06c004ce6fb32303cc2a6f405b6df  osx-native-depends-r3.tar.gz
23764c3fc29240d67a2e8f24c59ab988162450af21c5d226a974a0a69570629e  osx-depends-r3.tar.gz

These match. However, osx-depends-qt fails to build with the following error :(

In file included from ../3rdparty/clucene/src/CLucene/util/fileinputstream.cpp:26:
In file included from ../3rdparty/clucene/src/CLucene/util/jstreamsconfig.h:9:
In file included from ../3rdparty/clucene/src/CLucene/StdHeader.h:488:
In file included from ../3rdparty/clucene/src/CLucene/util/Misc.h:16:
In file included from /home/ubuntu/build/osx-cross-depends/build/qt-everywhere-opensource-src-5.2.1/qtbase/lib/QtCore.framework/Headers/QString:1:
In file included from /home/ubuntu/build/osx-cross-depends/build/qt-everywhere-opensource-src-5.2.1/qtbase/lib/QtCore.framework/Versions/5/Headers/qstring.h:50:
/home/ubuntu/build/osx-cross-depends/SDKs/MacOSX10.7.sdk/usr/include/c++/v1/string:1952:10: error: overload resolution selected implicitly-deleted copy assignment operator
    __r_ = _STD::move(__str.__r_);
         ^
/home/ubuntu/build/osx-cross-depends/SDKs/MacOSX10.7.sdk/usr/include/c++/v1/string:1942:9: note: in instantiation of member function 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__move_assign' requested here
        __move_assign(__str, true_type());
        ^
/home/ubuntu/build/osx-cross-depends/SDKs/MacOSX10.7.sdk/usr/include/c++/v1/string:1961:5: note: in instantiation of member function 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__move_assign' requested here
    __move_assign(__str, integral_constant<bool,
    ^
../3rdparty/clucene/src/CLucene/util/fileinputstream.cpp:80:19: note: in instantiation of member function 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::operator=' requested here
            error = "Could not close file '" + filepath + "'.";
                  ^
/home/ubuntu/build/osx-cross-depends/SDKs/MacOSX10.7.sdk/usr/include/c++/v1/memory:1941:5: note: copy assignment operator is implicitly deleted because '__compressed_pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__rep, std::__1::allocator<char> >' has a user-declared move constructor
    __compressed_pair(__compressed_pair&& __p)
    ^

@laanwj My intermediates line up with yours. What revision did you use for building bitcoin?

7a419a6

Match.

850b8e1ad5699f009b942b588378b3e5b5f1ad9a67b256bd53af63809281fa21  Bitcoin-Qt.dmg