Default to disable-wallet mode if the wallet doesn't exist #4240

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_05_disablewallet_default changing 2 files +12 −0

laanwj commented at 9:52 AM on May 28, 2014: member

Default to disable-wallet mode if the wallet doesn't exist, and require the user to tell the daemon to create it. I think this makes sense eventually, and is a further step toward removing the expectation that Bitcoin Core is a wallet.

Add a command line option -createwallet to create the wallet. Passing this option when the wallet already exists does nothing.

N.B.: The GUI still defaults to creating the wallet by default. There would first need to be a user-friendly way to create the wallet to change this behavior, for example through a menu option. This is going to be the next step if the idea is accepted.

Default to disable-wallet mode if the wallet doesn't exist

Default to disable-wallet mode if the wallet doesn't exist,
and require the user to tell the daemon to create it.
I think this makes sense eventually, and is a further step toward
removing the expectation the Bitcoin Core is a wallet.

Add a command line option `-createwallet` to create the wallet. Passing
this option when the wallet already exists does nothing.

N.B.: The GUI still defaults to creating the wallet by default. There would
first need to be a user-friendly way to create the wallet to change this
behavior, for example through a menu option. This is going to be the
next step if the idea is accepted.

73e705858f

cozz commented at 8:11 PM on May 30, 2014: contributor
I would like to suggest instead of having 2 options "disablewallet" and "createwallet", replace them with 1 option "enablewallet".
- enablewallet sets if the wallet is enabled or not (regardless if there is a wallet.dat)
- if no explicit choice by the user, it depends on whether wallet.dat exists or not
- the GUI always has an explicit choice, because we store an option in the qt-settings file (default=enabled) GUI could be overriden by command-line as usual
- disablewallet sets enablewallet to false for compatibility
- show better error message in case someone uses a wallet rpc in no-wallet mode: Method is disabled (to enable add enablewallet to your bitcoin.conf)
The code can be found here: https://github.com/cozz/bitcoin/commit/9eca0da59c7c06b87fd3975239339f92f10ffe12
laanwj commented at 12:57 PM on June 2, 2014: member

@cozz sounds good to me
jgarzik commented at 8:27 PM on June 2, 2014: contributor

I like the concept. Some concern about impact versus existing expectations. Seems like "ACK with release note" territory.
sipa commented at 9:50 PM on June 2, 2014: member

Agree with @jgarzik: like the idea, but needs clear announcement.
BitcoinPullTester commented at 6:41 AM on June 23, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4240_73e705858f5cb163e243304833f9aba756836dbe/ for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj added this to the milestone Future on Jul 4, 2014
laanwj commented at 6:54 AM on July 4, 2014: member

Postponing this to post-0.10.
laanwj closed this on Jul 4, 2014
bitcoin locked this on Sep 8, 2021
maflcko removed this from the milestone Future on Jul 23, 2025

Contributors