rename fNoListen to fListen and move to net #4247

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:listen changing 6 files +7 −7

Diapolo commented at 10:38 AM on May 29, 2014: none
- better code readability and it belongs to net
- this is a prerequisite for a pull to add -listen to the GUI

rename fNoListen to fListen and move to net

- better code readability and it belongs to net
- this is a prerequisite for a pull to add -listen to the GUI

53a088154c

Diapolo renamed this:
~~rename fNoListen to fListen an move to net~~
rename fNoListen to fListen and move to net
on May 29, 2014
BitcoinPullTester commented at 12:37 PM on May 29, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/53a088154ce4e1fc483afa120a9063811dd0e7ea for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
brandondahler commented at 2:31 AM on May 30, 2014: contributor
Basic code review and coverage search against master looks good to me.

Coverage search command:
```
find . -type f \( -iname "*.h" -o -iname "*.cpp" \) -exec grep "fNoListen" {} \; -print
```
theuni commented at 6:11 PM on May 30, 2014: member

@brandondahler fwiw, 'git grep fNoListen' is usually most helpful for this type of change.
Diapolo commented at 7:21 AM on June 3, 2014: none

@laanwj @sipa Should be no big deal, can you comment?
laanwj commented at 7:49 AM on June 3, 2014: member

@Diapolo Sure - I'm in favor of positive options instead of negative ones, and moving it to an implementation file where it's actually used makes sense. ACK
sipa commented at 9:47 PM on June 3, 2014: member

Untested ACK.
jgarzik referenced this in commit c79897af31 on Jun 4, 2014
jgarzik merged this on Jun 4, 2014
jgarzik closed this on Jun 4, 2014
Diapolo deleted the branch on Jun 4, 2014
dgenr8 commented at 6:07 PM on June 23, 2014: contributor

Bug: it is now necessary to set -listen=0 even when setting -connect= (and not setting -bind=). This does not match documentation: "-listen Accept connections from outside (default: 1 if no -proxy or -connect)".

This seems like it might be related to this change.
DrahtBot locked this on Sep 8, 2021

Contributors