Add vout to ListTransactions output #4255

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz12 changing 3 files +56 −43

cozz commented at 1:56 AM on May 30, 2014: contributor
Fixes #1613 and #4244.

Adds vout to void ListTransactions which affects the RPCs:
- listsinceblock
- listtransactions
- gettransaction
jgarzik commented at 6:59 PM on June 4, 2014: contributor

untested ACK
laanwj commented at 7:27 AM on July 8, 2014: member

Untested ACK. Needs rebase.
in src/wallet.h:None in 1122e8fff2 outdated
```
 442 | @@ -443,6 +443,7 @@ static void WriteOrderPos(const int64_t& nOrderPos, mapValue_t& mapValue)
 443 |      mapValue["n"] = i64tostr(nOrderPos);
 444 |  }
 445 |  
 446 | +typedef boost::tuple<CTxDestination, int64_t, int> output_t;
```
laanwj commented at 7:28 AM on July 8, 2014:

Hmm I'm not so sure about using a boost::tuple here. Why would this be preferable over a structure with named fields? With named fields the code is easier to read (ie .destination, .amount, .vout instead of .get<1> .get<2> .get<3>).
cozz commented at 8:38 AM on July 13, 2014: contributor
update:
- switched from boost::tuple to structure
Add vout to ListTransactions output 1b4568cb0f
cozz commented at 2:22 PM on July 15, 2014: contributor

rebased
BitcoinPullTester commented at 4:20 PM on July 15, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4255_1b4568cb0f00dd7a24575fe54c017e743c4e7d35/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 10:56 AM on July 18, 2014: member

Nice. Tested ACK.
laanwj merged this on Jul 18, 2014
laanwj closed this on Jul 18, 2014
laanwj referenced this in commit eaa9400781 on Jul 18, 2014
LinusU commented at 12:27 PM on July 18, 2014: none

@laanwj Sorry I never got the time to test this, glad too see that it got merged thought :) :+1:
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#1613 Add txout index to bitcoind json output #4244 Add vout to listsinceblock response