A few documentation fixes + added link to my Docker/LXC gitian-builder guide #4279

pull gdm85 wants to merge 1 commits into bitcoin:master from gdm85:master changing 1 files +22 −21

gdm85 commented at 9:43 AM on June 3, 2014: contributor
- provide correct URL for Debian 7.4 ISO + link at official ISO sources (was mentioned in this #4265 (comment))
- fix issue #4269: tell user to checkout correct bitcoin version before using the gitian descriptors
- add link to my guide + templates about using docker containers + LXC (I am planning to maintain this at work, also for future bitcoin versions)
gdm85 commented at 9:50 AM on June 3, 2014: contributor

@laanwj I did not include a fix for the sort issue #4274 here, that can be a separate PR or I can add another commit on this one.

The material I prepared on the guide is fully auditable and allows almost completely automated gitian builds leveraging Docker + LXC containers, this is easier and quicker than the VirtualBox VM approach, that's why I am proposing to add it; see also the diagram. I am confident that this will be helpful to developers and allow them to easily make more deterministic builds.
in doc/gitian-building.md:None in 14eec595e3 outdated
```
 207 | @@ -205,7 +208,7 @@ On Windows you can use putty[1] and WinSCP[2].
 208 |  
 209 |  For example to connect as `root` from a Linux command prompt use
 210 |  
 211 | -    $ ssh root@localhost -p 22222
 212 | +    $ ssh -o SendEnv= root@localhost -p 22222
```
laanwj commented at 9:58 AM on June 3, 2014:

This is just an example; I'm not sure it makes sense to add the -o SendEnv= here. It's much more important to do this inside the gitian builder itself.

gdm85 commented at 10:02 AM on June 3, 2014:

If the initial SSH environment is not poisoned, those coming afterwards will not be.

I agree it's not a fix, it's a workaround - doesn't hurt and will save time to developers before we have the proper fix in place in gitian-builder

laanwj commented at 10:03 AM on June 3, 2014:

But people could be using anything to connect to the outer VM (including GUI tools like putty, which likely don't have that setting). It' not the outer VM that should be deterministic but the inner one.

gdm85 commented at 10:28 AM on June 3, 2014:

I will remove this as discussed via IRC
gdm85 commented at 11:04 AM on June 3, 2014: contributor

commit updated to not suggest -o SendEnv=
laanwj commented at 1:32 PM on June 3, 2014: member
Nit: please use this format for commit messages:
```
First line: Title (~60 characters)
Second line: empty
Third line and after that: Longer description of the commit
```
Currently this shows as one long title in some tooling such as "git log --abbrev-commit".

Some documentation fixes + link to my Docker/LXC guide

I added a link to my guide about using docker containers + LXC (I am planning to maintain this at work
for future bitcoin versions), then I mentioned other virtualization options (KVM, LXC).
This commit includes a fix issue for documentation issue #4269 that consists in telling users to
checkout correct bitcoin version before using the gitian descriptors (otherwise all hell can break loose).
Also, I replaced URL for Debian 7.4 ISO with a correct one and added link to official Debian ISO sources.

a98b8707dc

gdm85 commented at 1:39 PM on June 3, 2014: contributor

@laanwj updated. Sorry but I am a bit new to git best practices
BitcoinPullTester commented at 2:09 PM on June 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/a98b8707dc5606a5c119a123b1b66d5e7ab5a815 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj merged this on Jun 3, 2014
laanwj closed this on Jun 3, 2014
laanwj referenced this in commit 06a4334a2f on Jun 3, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

gdm85

laanwj

BitcoinPullTester

Linked (view graph)

#4265 Include all build environment dependencies in gitian descriptors #4269 Gitian builds: first repo clone should checkout right tag