[Qt] style police and small addition in rpcconsole #4280

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:qt_fix_style changing 10 files +26 −21

Diapolo commented at 12:45 PM on June 3, 2014: none
- fix spaces, indentation and coding style glitches
[Qt] style police and small addition in rpcconsole
- fix spaces, indentation and coding style glitches
bbe1925ce3

in src/qt/rpcconsole.cpp:None in 0bd2d21b3e outdated

 636 | @@ -638,27 +637,33 @@ void RPCConsole::updateNodeDetail(const CNodeCombinedStats *combinedStats)
 637 |          ui->peerBanScore->setText(tr("Fetching..."));
 638 |  }
 639 |  
 640 | +// We override the virtual resizeEvent of the QWidget to adjust tables column
 641 | +// sizes as the tables width is proportional to the dialogs width.
 642 |  void RPCConsole::resizeEvent(QResizeEvent *event)
 643 |  {
 644 | +    if (ui->tabWidget->currentIndex() == 3) // peers tab
 645 | +        columnResizingFixer->stretchColumnWidth(PeerTableModel::Address);

laanwj commented at 12:55 PM on June 3, 2014:

Why check for the tab here? Does it matter what tab is visible for the functionality?

in src/qt/rpcconsole.cpp:None in 0bd2d21b3e outdated
```
 652 |  {
 653 | -    QWidget::showEvent(event);
 654 | -
 655 | -    // peerWidget needs a resize in case the dialog has non-default geometry
 656 | -    columnResizingFixer->stretchColumnWidth(PeerTableModel::Address);
 657 | +    if (ui->tabWidget->currentIndex() == 3) // peers tab
```
laanwj commented at 12:56 PM on June 3, 2014:

Same here. This looks like unnecessary logic, and if you do this, the following will fail:

Select another tab than 3

Hide the window

Show the window

Switch to tab 3

Statistics will not update
Diapolo commented at 12:58 PM on June 3, 2014:

Perhaps even the update start/stop is not necessary (what does it cost - even when minimized e.g.)!? I thought it would be good to only call that columnResizingFixer, when we are at the peers tab.

laanwj commented at 1:01 PM on June 3, 2014:

Let's word it differently: what does your change fix?

Diapolo commented at 1:02 PM on June 3, 2014:

I removed that change for know, so no code changes anymore, should be easy to merge now!

laanwj commented at 1:06 PM on June 3, 2014:

Well it was an honest question. I did notice that the debug window is much larger now by default, and haven't been able to find in a quick glance why this is (the default dimensions in the .ui file don't seem to have changed).

Diapolo commented at 1:07 PM on June 3, 2014:

I seem to have problems with the layout also... it's not bigger, but when selecting peers it's wildly resizing and doesn't work well also.

laanwj commented at 1:17 PM on June 3, 2014:

From what I remember it used to be that the debug window was wider than it was high. Now I get a higher window. This looks OK in the peers listing, but makes the bandwidth graph tab look funny. Maybe the automatic resizing behavior shouldn't really be there at all.
Diapolo commented at 1:20 PM on June 3, 2014: none

@laanwj OT - see this for problems with resizing:

We only use that resizefixer in receivecoins and transactionsview, perhaps it doesn't work well with the peers layout, which has an element right to the table!?
BitcoinPullTester commented at 1:22 PM on June 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bbe1925ce3e627fd405d83e3c947e1f430a1d720 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj merged this on Jun 3, 2014
laanwj closed this on Jun 3, 2014
laanwj referenced this in commit 6a6d7892c4 on Jun 3, 2014
Diapolo deleted the branch on Jun 3, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester