CWallet: fix nTimeFirstKey init, by making constructor init common code #4282

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:fix-wallet-init changing 1 files +10 −11

jgarzik commented at 4:56 PM on June 3, 2014: contributor

nTimeFirstKey was only initialized properly in one of two constructors.

Don't repeat yourself etc.
CWallet: fix nTimeFirstKey init, by making constructor init common code
Don't repeat yourself etc.
d04fd3e2af
BitcoinPullTester commented at 5:34 PM on June 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d04fd3e2afaf9cdab21aa8f3abb5a5a2c48118cc for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
tm314159 commented at 10:03 PM on June 3, 2014: contributor

Looks ok to me. I can rerun valgrind after merging.
laanwj commented at 6:44 AM on June 4, 2014: member

ACK @tm314159 No need to wait for merging for that, better to get this done in one go
jgarzik referenced this in commit b8ac6cdf53 on Jun 4, 2014
jgarzik merged this on Jun 4, 2014
jgarzik closed this on Jun 4, 2014
tm314159 commented at 10:09 PM on June 4, 2014: contributor

I did a git pull and tested it. I can't replicate the original problem, so looks good.
jgarzik deleted the branch on Aug 24, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors