Important: This makes it obvious, that we need to re-think the settings/options handling, as GUI settings are processed before any parameter-interaction (which is mostly important for network stuff) in AppInit2()!
Important: This makes it obvious, that we need to re-think the settings/options handling, as GUI settings are processed before any parameter-interaction (which is mostly important for network stuff) in AppInit2()!
So does this work at all, until then?
It is working, but we can't be sure (and even NOW this is the case) what side effects the missing (or too late) parameter interaction has.
The side effects are quite predictable, IMHO: you get the same kind of interactions between parameters that you'd get when setting the arguments from the command line. However, the parameter interaction only affects defaults. As the GUI sets almost all command line parameters, the defaults mangling won't do much.
Edit: Anyhow I'll test and merge this, the options issue can be handled some other time.
ACK, works for me.
Nit: commit message is wrong: you define DEFAULT_LISTEN, not DEFAULT_PROXY :)
- add DEFAULT_LISTEN in net.h and use in the code (shared
setting between core and GUI)
Important: This makes it obvious, that we need to re-think the
settings/options handling, as GUI settings are processed before
any parameter-interaction (which is mostly important for network
stuff) in AppInit2()!
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/56b07d2dcdec336173b866210c535439b03416a1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.