As reported in #4296.
Fix potential deadlock in PeerTableModel #4297
pull ashleyholman wants to merge 1 commits into bitcoin:master from ashleyholman:gui_peers changing 1 files +2 −2-
ashleyholman commented at 7:31 AM on June 6, 2014: contributor
-
qt: PeerTableModel: Fix potential deadlock. #4296 b917555b04
-
laanwj commented at 7:35 AM on June 6, 2014: member
Haven't tested myself whether it solves the problem, but ACK on the code change it makes more sense this way.
I'm a bit ashamed that I didn't catch this in the review. Will add a note about LOCK/TRY_LOCK to the development/review notes I'm writing.
-
ashleyholman commented at 8:11 AM on June 6, 2014: contributor
FWIW, I reproduced the deadlock warning in the original code, and this patch made it go away.
- laanwj merged this on Jun 6, 2014
- laanwj closed this on Jun 6, 2014
- laanwj referenced this in commit 345cb52e8b on Jun 6, 2014
-
BitcoinPullTester commented at 8:30 AM on June 6, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b917555b04b501efe22990eedadc59ae8baa2519 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- MarcoFalke locked this on Sep 8, 2021
