gdm85
commented at 8:07 AM on June 8, 2014:
contributor
In this bitcoin.conf I use basically the config from wiki plus a few changes:
removed reference to allow payment via IP
added reference to regtest
It's important that eventually we get this default config for Debian up to standards e.g. all options in the default config, commented with the default value they have when running. This is a first step.
in
contrib/debian/examples/bitcoin.conf:None
in
d87979e74boutdated
Also: -connect disables listening (by default, you can re-enable it with -listen).
in
contrib/debian/examples/bitcoin.conf:None
in
d87979e74boutdated
66 | +#rpctimeout=30
67 |
68 | # By default, only RPC connections from localhost are allowed. Specify
69 | # as many rpcallowip= settings as you like to allow connections from
70 | -# other hosts (and you may use * as a wildcard character): 71 | +# other hosts (and you may use * as a wildcard character).
in
contrib/debian/examples/bitcoin.conf:None
in
d87979e74boutdated
7 |
8 | # Run on the test network instead of the real bitcoin network.
9 | -#testnet=1 10 | +#testnet=0 11 | + 12 | +# Run on the regression test network
laanwj
commented at 11:08 AM on June 9, 2014:
member
Thanks for trying to improve the documentation!
gdm85
commented at 8:42 AM on June 10, 2014:
contributor
@laanwj you're welcome! Since this was not referenced by any other PR/commit I will update this PR with the proposed amendments
Also switch the (unused) verification code to low-s instead of even-s.
a81cd968 introduced a malleability breaker for signatures
(using an even value for S). In e0e14e43 this was changed to
the lower of two potential values, rather than the even one.
Only the signing code was changed though, the (for now unused)
verification code wasn't adapted.
795a9a5dc4
Fix transaction tests
Conflict between low-s (6fd7ef2) and test updates in d3a33fc.
75b5258012
Remove NumBlocksOfPeers
Generally useless information. Only updates on connect time, not after
that. Peers can easily lie and the median filter is not effective in
preventing that.
In the past it was used for progress display in the GUI but
`CheckPoints::guessVerificationProgress` provides a better way that is now used.
It was too easy to mislead it. Peers do lie about it in practice, see issue #4065.
From the RPC, `getpeerinfo` gives the peer raw values, which are more
useful.
700b5b326d
Deduplicate shared code between uint160 and uint2563c756ece90
Exception instead of assigning 0 in case of wrong vector lengtheac09b2139
Add multiplication and division to uint160/uint256ae87b1138b
Move {Get,Set}Compact from bignum to uint256402c56a9d3
util: add parseint32 function with strict error reporting
None of the current integer parsing functions in util
check whether the result is valid and fits in the range
of the type. This is required for less sloppy error reporting.
e6d92f7aa8
Use new function parseint32 in SplitHostPort
Use the new function parseint32 in SplitHostPort instead of calling
strtol directly.
0424501c92
net: Add CSubNet class for subnet matching188e2e6a92
rpc: Use netmasks instead of wildcards for IP address matching
`-rpcallowip` currently has a wacky wildcard-based format. After this
commit it will accept the more standard format, for example:
- Ranges with netmask 127.0.0.0/255.255.255.0, ::/0
- Ranges with cidr 12.3.4.5/24, 12:34:56:78:9a:bc:de:00/112
- Loose IPs ::1, 127.0.0.1
Trying to use the old *?-based format will result in an error message at
launch.
726deb0537
Remove unused function WildcardMatch
No longer necessary after implementing netmask-based matching.
Also remove a longer-unused function `skipspaces`.
b6bf407f95
Add tests for BoostAsioToCNetAddr13b6a0199d
fixes #4163e8f3c7ac90
Reduce bignum.h now it is only needed for scriptnum_testsefc13749f3
Move bignum.h to test/510e84bf61
Switch stdout to line buffering
Use line buffering (instead of block buffering) so that messages arrive
immediately in systemd-journald, tail -f debug.log, and the like.
a742f26f55
Squashed 'src/leveldb/' changes from 9094c7f..7924331
Move base58.h implementation code to base58.cpp3e4e51fc2c
Remove dummy PRIszX macros for formatting
Size specifiers are no longer needed now that we use typesafe tinyformat
for string formatting, instead of the system's sprintf.
No functional changes.
This continues the work in #3735.
459f820dc6
rpc: pass errors from async_accept
According to the [boost::asio documentation](http://www.boost.org/doc/libs/1_55_0/doc/html/boost_asio/reference/basic_socket_acceptor/async_accept/overload2.html),
the function signature of the handler must be:
void handler(
const boost::system::error_code& error // Result of operation.
);
We were binding *all* the arguments, instead of all but the error,
resulting in nullary function that never got the error. Fix this
by adding an input argument substitution.
771a510058
rpc: Make sure conn object is always cleaned up
Make sure conn object always gets cleaned up by using a
`boost::shared_ptr`.
This makes valgrind happy - before this commit, one connection object
always leaked at shutdown, as well as can avoid other leaks, when
for example an exception happens.
Also add an explicit Close() to the !ClientAllowed path to make it similar
to the normal path (I'm not sure whether it is needed, but it
can't hurt).
fd0dfdfab2
doc: remove mention of `-rpctimeout` from man page
That option hasn't existed for a long time.
e1d64fc4a5
rpc: keep track of acceptors, and cancel them in StopRPCThreads
Fixes #4156.
The problem is that the boost::asio::io_service destructor
waits for the acceptors to finish (on windows, and boost 1.55).
Fix this by keeping track of the acceptors and cancelling them before
stopping the event loops.
b2430bc73e
qt: periodic language update
Pull updated translations from Transifex.
Add mn (Mongolian) language.
Do not update English translation for now as we want to keep
compatibility with 0.9.
f26b062c40
Fix build in OS X 10.92908fc5e38
Add -rpcbind option to allow binding RPC port on a specific interface
Add -rpcbind command option to specify binding RPC service on one
or multiple specific interfaces.
Functionality if -rpcbind is not specified remains the same as before:
- If no -rpcallowip specified, bind on localhost
- If no -rpcbind specified, bind on any interface
Implements part of #3111.
1956b6e824
Support IPv6 lookup in bitcoin-cli even when IPv6 only bound on localhost
First query in the current way (intelligently determining which network
has a non-localhost interface). If this does not succeed, try plain
lookup.
Needed for testing.
Fixes #1827 by always allowing IPv6 to be used.
bca14ab256
Add Python test for -rpcbind and -rpcallowip
Add a new test, `rpcbind_test.py`, that extensively tests the new
`-rpcbind` functionality.
f373a6b924
switch from boost int types to <stdint.h>388cc1b10e
json_spirit: #include <stdint.h>b26384466a
removed a few unnecessary castsf35f3efaf8
remove ParseString(...) which is never used5312d7f475
SetupEnvironment() - clean commit9a354eacd8
ProcessGetData(): abort if a block file is missing from disk8578ca190d
LoadBlockIndexDB(): Require block db reindex if any blk*.dat files are missing.72add09639
Remove extraneous c_str0933ce4cb4
Fix NameError in macdeploy scripta1ef03a0c4
Remove fDaemon flag checking on return from main(), which is useless and looks really strange.96d57a1833
gitian: Add OSX build descriptors
Github-Pull: #4185
Rebased-By: Wladimir J. van der Laan
Rebased-From: bb5da27, 2288206, 7fe8fe6, f76db78, ebcf375, fa1ed7c, 397e9b8
f7cdd212d4
qt: Periodic language update1b47fd68ce
Add missing LOCK(cs_main)695887a379
Remove forward declaration for non-existent class CCoinsDB
Found by stephenreed on #bitcoin.dev.
43dd40211e
Fix addnode "onetry": Connect with OpenNetworkConnection251b993d68
Update test_main.cpp
i think should delete (#include "bitcoin-config.h")。
3f040b799a
Replace non-threadsafe strerror
Log the name of the error as well as the error code if a network problem
happens. This makes network troubleshooting more convenient.
Use thread-safe strerror_r and the WIN32 equivalent FormatMessage.
4837acab06
Replace non-threadsafe gmtime and setlocale
Make DateTimeStrFormat use boost::posix_time.
Also re-enable the util_DateTimeStrFormat tests, as they are no
longer platform specific.
cc1d46011c
qt: Periodic language update
Last-minute language update before release 0.9.2.
ea51fc67ef
Add Tips and Tricks section to README813b3bc00d
doc: Add historical release notes for 0.9.1884c38c4ca
Fix warning when compiling in OS X4a60941c2e
Qt: Fix monospace font in osx 10.9
The "Monospace" hint was added in Qt 4.8, and it works as intended as opposed
to "TypeWriter" which fails to load a font.
3e88cdc969
remove CWallet::AddReserveKey which is never used2e7a98f990
remove CTransaction::IsNewerThan which is never usedf94a265c06
remove LogException( ) which is never used83f07146b6
remove LookupHostNumeric( ) which is never usedb8718712eb
remove GetMedianTime( ) which is never usede92defbb0b
remove CPubKey::VerifyCompact( ) which is never used4344d7d76a
Remove redundant c_strb29974178d
Add CODESEPARATOR/FindAndDelete() testsf98b0a8d0f
Fix incorrect checkpoint data for testnet34f201c7e8f
Doc: Always use absolute pathsc6363ef2f4
Spelling fix in comment
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: 3704a6a
31a2910264
[Qt] Fix Start bitcoin on system login0afe0abfce
add DEFAULT_UPNP constant in net
- as this is a shared Core/GUI setting, this makes it easier to keep them
in sync (also no new includes are needed)
cc67fbda8f
release: Bump the OSX SDK to 10.7 for gitian builds
This fixes the display on Retina Macbooks. It also moves us away from depending
on the ancient XCode3 sdk.
f5b7be4dc2
gitian: Add cfields to gitian download scriptsa614578501
Fix name of Cory's pgp key6737a52b46
No references to centralized databases in help text.4e9c606885
Remove unused imports in macdeploy script3108f879a5
osx: Fix missing dock menu with qt5
Qt5 Removed the qt_mac_set_dock_menu function and left no replacement. It was
later re-added and deprecated for backwards-compatibility.
Qt5.2 adds the non-deprecated QMenu::setAsDockMenu(). Use that when possible.
cc6c6e31b6
doc: Clarify wording about testing in README.md
Weaken and clarify the wording a bit, it currently implies that we get
more pull requests than we can ever handle which discourages
contribution.
d63f7d7ffb
remove dup of extern int nConnectTimeout; in netbase3cd30813e5
Limit number of known addresses per peer4f76ff2a1b
Periodic language update
Pull updated translations from Transifex before 0.9.2
57a8590a58
Fix stray uppercase A in tx_valid.json.7c2bf39313
Use pnode->nLastRecv as sync score directly
NodeSyncScore() should find the node which we recv data most recently, so put a negative sign to pnode->nLastRecv is indeed wrong.
Also change the return value type to int64_t.
Signed-off-by: Huang Le <4tarhl@gmail.com>
Make links on 'About Bitcoin Core' into clickable (squashed 5 comits into one)
Made the following links clickable:
http://www.opensource.org/licenses/mit-license.php
http://www.openssl.org/
eay@cryptsoft.com
(Squashed commits into one commit as suggested by @laanwj)
Replaced label with text browser on About Bitcoin Core Screen
So that the links on the About screen can be clickable
Replaced html property with text property
I have now removed unnecessary html so this should make life easier for
translators and you @Diapolo :). What do you think?
The size of the window needs to change
The size of the window needs to change when you make links clickable.
Thanks for pointing that out @laanwj
Using the https://www.openssl.org over the http link
Using the https://www.openssl.org over the http link as suggested by
@Diapolo
- replaces checks in SendCoinsDialog::handlePaymentRequest() that belong
to PaymentServer (normal URIs are special cased, as only an isValid
check is done on BTC addresses)
- prevents the client to handle payment requests that do not match the
clients network and shows an error instead (mainly a problem with
drag&drop payment requests onto the client window)
- includes some small comment changes also
f8e900bc44
added many rpc wallet tests
deleted the empty no throw test in rpc_wallet_tests line 65
fixed some comments
starting verify tests
finished verify message tests
changed some comments
Qt: Add GUI view of peer information. #41331ee031fbde
[Qt] style police and small addition in rpcconsole
- fix spaces, indentation and coding style glitches
de428ff1d4
Some documentation fixes + link to my Docker/LXC guide
I added a link to my guide about using docker containers + LXC (I am planning to maintain this at work
for future bitcoin versions), then I mentioned other virtualization options (KVM, LXC).
This commit includes a fix issue for documentation issue #4269 that consists in telling users to
checkout correct bitcoin version before using the gitian descriptors (otherwise all hell can break loose).
Also, I replaced URL for Debian 7.4 ISO with a correct one and added link to official Debian ISO sources.
fe4a974cb6
VerifyDB progress4dbfddb0ab
Remove template matching params from GetOpName()
Since they are not real opcodes, being reported as OP_UNKNOWN is less confusing for human-readable decoding.
Signed-off-by: Huang Le <4tarhl@gmail.com>
ae7589d63d
Make max number of orphan blocks kept in memory a startup parameter (fixes #4253)b76c04a018
rename fNoListen to fListen and move to net
- better code readability and it belongs to net
- this is a prerequisite for a pull to add -listen to the GUI
2d1e52efda
CWallet: fix nTimeFirstKey init, by making constructor init common code
Don't repeat yourself etc.
f22f00e8dc
gitian: make linux qt intermediate deterministic
A qt installation date snuck into the host utils (lrelease etc)
This doesn't affect the end product, so no dependency version bump.
It also doesn't explain why gavin's and mine build is different
5f81f6fb5a
doc: Update hash in release process for new windows deps intermediate
This was forgotten in 25d4911.
693344e1d8
log used config file to debug.log on startupb511c50a29
Remove side effect in assertion in ProcessGetData
A side-effect was introduced into an assertion in 7a0e84d. This commit
fixes that.
9f96f4d56f
[Qt] add BerkeleyDB version info to RPCConsole
- to match info function between debug.log and RPCConsole
f3d9b1bcc1
Fix GUI build with `--disable-wallet`
fe6bff2 and 65f78a1 broke it. Minor build changes.
dd9bf25bd0
Remove global strWalletFile
As it says on the tin. There is no need to have this variable be
global, it's only used in AppInit2.
4643356287
build: Switch to non-recursive make
Build logic moves from individual Makefile.am's to include files, which
the main src/Makefile.am includes. This avoids having to manage a gigantic
single Makefile.
TODO: Move the rules from the old Makefile.include to where they actually
belong and nuke the old file.
cacd56641e
build: delete old Makefile.am'sc02fba776c
build: add stub makefiles for easier subdir builds158781845e
build: nuke Makefile.include from orbit
Rules and targets no longer need to be shared between subdirectories, so
this is no longer needed.
05ef21c729
build: Tidy up file generation output
- Some file generation was still noisy, silence it.
- AM_V_GEN is used rather than @ so that 'make V=1' works as intended
- Cut down on file copies and moves when using sed, use pipes instead
- Avoid the use of top_ and abs_ dirs where possible
7982470688
build: avoid the use of top_ and abs_ dir paths
Using them has the side effect of confusing the dependency-tracking logic.
a7f12a5900
build: quit abusing AM_CPPFLAGS
Now that the build is non-recursive, adding to AM_CPPFLAGS means adding to
_all_ cppflags.
Logical groups of includes have been added instead, and are used individually
by various targets.
Use CFeeRate instead of an int64_t for quantities that are
fee-per-size.
Helps prevent unit-conversion mismatches between the wallet,
relaying, and mining code.
846dd484cd
Allow multiple regression tests to run at once
Choose ports at startup based on PID, so multiple regression tests
can run on the same system at the same time.
82feec772a
estimatefee / estimatepriority RPC methods
New RPC methods: return an estimate of the fee (or priority) a
transaction needs to be likely to confirm in a given number of
blocks.
Mike Hearn created the first version of this method for estimating fees.
It works as follows:
For transactions that took 1 to N (I picked N=25) blocks to confirm,
keep N buckets with at most 100 entries in each recording the
fees-per-kilobyte paid by those transactions.
(separate buckets are kept for transactions that confirmed because
they are high-priority)
The buckets are filled as blocks are found, and are saved/restored
in a new fee_estiamtes.dat file in the data directory.
A few variations on Mike's initial scheme:
To estimate the fee needed for a transaction to confirm in X buckets,
all of the samples in all of the buckets are used and a median of
all of the data is used to make the estimate. For example, imagine
25 buckets each containing the full 100 entries. Those 2,500 samples
are sorted, and the estimate of the fee needed to confirm in the very
next block is the 50'th-highest-fee-entry in that sorted list; the
estimate of the fee needed to confirm in the next two blocks is the
150'th-highest-fee-entry, etc.
That algorithm has the nice property that estimates of how much fee
you need to pay to get confirmed in block N will always be greater
than or equal to the estimate for block N+1. It would clearly be wrong
to say "pay 11 uBTC and you'll get confirmed in 3 blocks, but pay
12 uBTC and it will take LONGER".
A single block will not contribute more than 10 entries to any one
bucket, so a single miner and a large block cannot overwhelm
the estimates.
251fda9977
gitian: upgrade OpenSSL to 1.0.1h
Upgrade for https://www.openssl.org/news/secadv_20140605.txt
Just in case - there is no vulnerability that affects ecdsa signing or
verification.
The MITM attack vulnerability (CVE-2014-0224) may have some effect on
our usage of SSL/TLS.
As long as payment requests are signed (which is the common case), usage
of the payment protocol should also not be affected.
The TLS usage in RPC may be at risk for MITM attacks. If you have
`-rpcssl` enabled, be sure to update OpenSSL as soon as possible.
3998f729dd
qt: Periodic translation update2e79069358
Fix compiler warnings
Fixes the following compiler warning
```
miner.cpp: In constructor ‘COrphan::COrphan(const CTransaction*)’:
miner.cpp:69:14: warning: ‘COrphan::feeRate’ will be initialized after [-Wreorder]
CFeeRate feeRate;
^
miner.cpp:68:12: warning: ‘double COrphan::dPriority’ [-Wreorder]
double dPriority;
^
miner.cpp:71:5: warning: when initialized here [-Wreorder]
COrphan(const CTransaction* ptxIn) : ptx(ptxIn), feeRate(0), dPriority(0)
```
5a1ac132cd
Add updated bitcoin.conf from wiki + some updates26903aefa5
Update translation_process.md
Qt changed to Bitcoin Core
b7600f1775
Get rid of the static chainMostWork (optimization)06283ca75e
Allow ActivateBestChain to release its lock on cs_mainf9631b5d2b
Move all post-chaintip-change notifications to ActivateBestChainedd0076be4
Replace virtual methods with static attributes, chainparams.h depends on
protocol.h instead of the other way around
c5d73b00f6
net.h was using std namespace through chainparams.h included in protocol.hab6df04621
Use Params().NetworkID() instead of TestNet() from the payment protocol8f1abd6b76
[Qt] Improve rpc console history behavior0b8ce70670
[Qt] Remove CENT-fee-rule from coin control completelya93ee3e6b9
gdm85
commented at 9:46 AM on June 10, 2014:
contributor
will provide a new PR
gdm85 closed this on Jun 10, 2014
laanwj
commented at 10:45 AM on June 10, 2014:
member
You almost never need to open a new PR, you can just push -f to the branch of the old one.
gdm85
commented at 10:57 AM on June 10, 2014:
contributor
@laanwj right, except that here I had first merged from upstream and then when forking again I got a weird GitHub issue (you can still see this PR as coming from 'unknown repository'). The nice GitHub support guys answered quickly allowing me to use the new fork and now I have made #4317
In future I might not want to merge from upstream before doing a push -f
This pull does not merge cleanly onto current master
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.
laanwj
commented at 11:31 AM on June 10, 2014:
member
If you pull from upstream you should do pull --rebase (or alternatively, fetch and then rebase). You don't want to introduce merge commits.
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-04-15 00:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me