Make mining support optional #4335

sipa commented at 9:50 PM on June 12, 2014: member

Intention: make it possible for a libsecp256k1 experimental build mode to disable wallet and mining.

BitcoinPullTester commented at 9:58 PM on June 12, 2014: none

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/4e7d2ae985159c22a727d729ebc2a8d0325f0f63 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Make mining support optional aa6767c5a2

Diapolo commented at 10:02 PM on June 12, 2014: none

Is this an internal-miner removal via back door ;)!?

sipa commented at 10:04 PM on June 12, 2014: member

It removes much more than the internal miner. It removes the ability to construct new blocks and everything related to it.

But it's compile-time optional.

in src/rpcserver.cpp:None in aa6767c5a2

 269 | @@ -268,8 +270,10 @@ static const CRPCCommand vRPCCommands[] =
 270 |      { "createmultisig",         &createmultisig,         true,      true ,      false },
 271 |      { "validateaddress",        &validateaddress,        true,      false,      false }, /* uses wallet if enabled */
 272 |      { "verifymessage",          &verifymessage,          false,     false,      false },
 273 | +#ifdef ENABLE_MINING
 274 |      { "estimatefee",            &estimatefee,            true,      true,       false },
 275 |      { "estimatepriority",       &estimatepriority,       true,      true,       false },
 276 | +#endif

luke-jr commented at 10:05 PM on June 12, 2014:

What do these have to do with mining?

sipa commented at 10:05 PM on June 12, 2014:

They're misplaced in rpcmining.cpp.

in src/rpcserver.cpp:None in aa6767c5a2

 254 |      /* Mining */
 255 |      { "getblocktemplate",       &getblocktemplate,       true,      false,      false },
 256 |      { "getmininginfo",          &getmininginfo,          true,      false,      false },
 257 |      { "getnetworkhashps",       &getnetworkhashps,       true,      false,      false },
 258 |      { "submitblock",            &submitblock,            false,     true,       false },
 259 | +#endif // ENABLE_MINING

luke-jr commented at 10:05 PM on June 12, 2014:

Should submitblock be included here?

in src/Makefile.test.include:None in aa6767c5a2

  63 | +  test/miner_tests.cpp
  64 | +endif
  65 | +
  66 |  test_test_bitcoin_SOURCES = $(BITCOIN_TESTS) $(JSON_TEST_FILES) $(RAW_TEST_FILES)
  67 |  test_test_bitcoin_CPPFLAGS = $(BITCOIN_INCLUDES) -I$(builddir)/test/ $(TESTDEFS)
  68 |  test_test_bitcoin_LDADD = $(LIBBITCOIN_SERVER) $(LIBBITCOIN_CLI) $(LIBBITCOIN_COMMON) $(LIBLEVELDB) $(LIBMEMENV) \

theuni commented at 10:13 PM on June 12, 2014:

Doesn't this need $(LIBBITCOIN_MINING) if ENABLE_MINING ?

sipa commented at 10:14 PM on June 12, 2014: member

Too many problems with this for now. I'll reopen when I've addressed them.

sipa closed this on Jun 12, 2014

MarcoFalke locked this on Sep 8, 2021