It's considered bad form to import things into the global namespace in a header. Put it in the cpp files where it is needed instead.
Remove `using namespace std` from header file #4349
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_06_stray_using_namespace changing 9 files +21 −13-
laanwj commented at 2:31 PM on June 16, 2014: member
-
jgarzik commented at 2:34 PM on June 16, 2014: contributor
ACK
-
theuni commented at 2:34 PM on June 16, 2014: member
untested, but +1 for sure. I've been wanting to get to this for a while.
-
09eb201b1b
Remove `using namespace std` from header file
It's considered bad form to import things into the global namespace in a header. Put it in the cpp files where it is needed instead.
-
BitcoinPullTester commented at 3:50 PM on June 16, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e6eb4b72bce8c9565aff8b83378429013cf64654 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj merged this on Jun 16, 2014
- laanwj closed this on Jun 16, 2014
- laanwj referenced this in commit 529047fcd1 on Jun 16, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors