build: gitian-osx: remove old hard-coded sdk path #4350

pull theuni wants to merge 1 commits into bitcoin:master from theuni:osx-gitian-remove-path changing 3 files +15 −17
  1. theuni commented at 3:06 PM on June 16, 2014: member

    This path was added to work around a bug in the 10.6 sdk that is no longer present in 10.7 or later. Also, remove the -B path in LDFLAGS, since it's not needed and wasn't used anyway.

    Bumped revisions because the intermediates change, but the final dmg is unaffected.

  2. build: gitian-osx: remove old hard-coded sdk path
    This path was added to work around a bug in the 10.6 sdk that is no longer
    present in 10.7 or later. Also, remove the -B path in LDFLAGS, since it's not
    needed and wasn't used anyway.
    
    Bumped revisions because the intermediates change, but the final dmg is
    unaffected.
    4ea1aa48a9
  3. theuni referenced this in commit 2869b1349b on Jun 16, 2014
  4. laanwj commented at 3:23 PM on June 16, 2014: member

    It's too bad that this needs a rebuild of qt :/

    As this doesn't affect the end result at all, I'd vote for postponing this until another change to the dependencies in needed (such as a Qt upgrade).

    ACK apart from that

  5. theuni commented at 3:31 PM on June 16, 2014: member

    Fine by me. I mainly did it to verify that it would not change the output. Since it doesn't, there's no rush at all.

  6. laanwj added the label Build system on Jun 16, 2014
  7. BitcoinPullTester commented at 11:41 PM on June 22, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4350_4ea1aa48a92c2f3f152684ef3814ea68c7571bbe/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  8. laanwj commented at 9:10 AM on July 25, 2014: member

    @theuni I suppose we can close this as it is included in your complete gitian descriptors overhaul?

  9. theuni commented at 2:30 PM on July 25, 2014: member

    Yep.

  10. theuni closed this on Jul 25, 2014

  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me