Bitcoin qt opens in testnet mode when presented with a BIP-72 link with no fallback. #4355

haight6716 commented at 5:01 AM on June 17, 2014: contributor

This valid bip-72 link opens bitcoin qt in testnet mode: bitcoin:?r=http://www.example.com/

It must need to parse the payment request before it can decide if it's testnet or not. Chicken and egg. Do we need a testnet: protocol? testnet:?r=http://www.example.com/

Thanks!

laanwj added the label Wallet on Jun 17, 2014

Diapolo commented at 6:07 AM on June 17, 2014: none

This does not open a testnet instance for me. Which version are you using?

haight6716 commented at 7:46 AM on June 17, 2014: contributor

Sorry, should have checked that - v0.9.1.0-g026a939-beta. I'm pasting the URL into chrome and letting it launch the wallet. That's when I observe the problem. This is ubuntu. Maybe an issue with the OS, hm?

haight6716 commented at 6:08 AM on June 25, 2014: contributor

No, it isn't the OS/browser launcher. I get the same results from the command line:

$ bitcoin-qt 'bitcoin:?r=http://www.example.com/'

Launches testnet. whereas

$ bitcoin-qt 'bitcoin:1NXXeQRyMFFFRfyUix2o7mk1vhvk2Nxp78?r=http://www.example.com/'

Launches normally.

Maybe already fixed in head if you can't repro?

laanwj commented at 6:09 AM on June 25, 2014: member

Yeah, could be, though please test with the latest release (0.9.2.1) first.

haight6716 commented at 7:05 AM on June 25, 2014: contributor

Just compiled with code from master, still see the problem. Bitcoin Core version v0.9.99.0-27383b9 (64-bit)

Looking for a fix myself since I have the code now, but my c++ is pretty rusty.

haight6716 referenced this in commit f860e9aac0 on Jun 25, 2014

laanwj commented at 7:28 AM on June 25, 2014: member

Will that change still open legacy Bitcoin URIs with a testnet address in a testnet instance?

haight6716 referenced this in commit d73901a0d7 on Jun 25, 2014

haight6716 referenced this in commit 10eb58dfb6 on Jun 25, 2014

haight6716 referenced this in commit 908535e3db on Jun 25, 2014

haight6716 referenced this in commit 01c46cc9b7 on Jun 25, 2014

haight6716 referenced this in commit e215d32895 on Jun 25, 2014

haight6716 referenced this in commit 4210835f2f on Jun 25, 2014

haight6716 commented at 8:16 PM on June 25, 2014: contributor

Sorry for all the trial & error here. Wasn't sure how best to revise the patch best. That last is the only one you need (4210835).

haight6716 referenced this in commit bffc63073a on Jul 1, 2014

laanwj closed this on Jul 2, 2014

laanwj referenced this in commit bf75a3d3fd on Aug 18, 2014

MathyV referenced this in commit e779613ad2 on Nov 3, 2014

MarcoFalke locked this on Sep 8, 2021