Why set receive and send buffer size to <n>_1000 bytes, i think it should be <n>_1024 bytes.
change buffer size from 1000 bytes to 1024 bytes #4361
pull LongShao007 wants to merge 2 commits into bitcoin:master from LongShao007:master changing 1 files +2 −2-
LongShao007 commented at 5:47 AM on June 18, 2014: contributor
-
49675884c4
Merge pull request #1 from bitcoin/master
Merge pull request
-
69f72d2564
change buffer size from 1000 bytes to 1024 bytes
Why set receive and send buffer size to <n>*1000 bytes, i think it should be <n>*1024 bytes.
-
laanwj commented at 5:49 AM on June 18, 2014: member
No, it should not, we use SI units (kB, MB) everywhere not MiB, KiB.
- laanwj closed this on Jun 18, 2014
-
luke-jr commented at 6:00 AM on June 18, 2014: member
Nit: KB is unambiguously 1024 bytes. The SI unit is kB (lowercase k).
-
LongShao007 commented at 6:14 AM on June 18, 2014: contributor
dbcache size and network traffic use MiB, KiB.
-
laanwj commented at 6:33 AM on June 18, 2014: member
For dbcache size it's for specific database implementation reasons, if I remember correctly.
For network traffic we shouldn't be using MiB, KiB at all! If that is the case, feel free to change it.
-
LongShao007 commented at 11:56 AM on June 18, 2014: contributor
it need to change lots of code (include resource of QT), and debug it in Linux, i don't have enough ablity and time to change it, sorry!
- MarcoFalke locked this on Sep 8, 2021
Contributors