AvailableCoins: acquire cs_main mutex #4371

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +1 −1

ghost commented at 12:59 PM on June 20, 2014: none

It's required when called from WalletModel
AvailableCoins: acquire cs_main mutex
It's required when called from WalletModel
ea3acaf383
laanwj commented at 1:14 PM on June 20, 2014: member

What is it needed for? Does something called inside AvailableCoins need/acquire the cs_main lock?
ghost commented at 1:19 PM on June 20, 2014: none

AvailableCoins() calls IsFinalTx() which requires cs_main
laanwj commented at 1:20 PM on June 20, 2014: member

ok, clear, ACK
BitcoinPullTester commented at 1:54 PM on June 20, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ea3acaf383ade60d39643b786db5b6942b8b7991 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
gavinandresen commented at 2:26 PM on June 20, 2014: contributor

ACK
laanwj merged this on Jun 20, 2014
laanwj closed this on Jun 20, 2014
laanwj referenced this in commit aaacfa0898 on Jun 20, 2014
unknown deleted the branch on Jun 20, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors