Show more info on service bits #4380

pull petertodd wants to merge 2 commits into bitcoin:master from petertodd:more-nservices-info changing 2 files +12 −2

petertodd commented at 1:13 PM on June 21, 2014: contributor

Show service bits advertised by the local node in getinfo as well as showing full 64-bits.

Also as per mailing list discussion add a comment about the bits reserved for experimental use.
jgarzik commented at 2:28 PM on June 21, 2014: contributor

I think "getnetworkinfo" is a more appropriate place for this item to be exported.

ACK the rest.
petertodd commented at 3:36 PM on June 21, 2014: contributor

@jgarzik Good idea - I didn't know we added getnetworkinfo.

Fixed.

in src/rpcnet.cpp:None in e84673f20c outdated

 114 | @@ -115,7 +115,7 @@ Value getpeerinfo(const Array& params, bool fHelp)
 115 |          obj.push_back(Pair("addr", stats.addrName));
 116 |          if (!(stats.addrLocal.empty()))
 117 |              obj.push_back(Pair("addrlocal", stats.addrLocal));
 118 | -        obj.push_back(Pair("services", strprintf("%08x", stats.nServices)));
 119 | +        obj.push_back(Pair("services", strprintf("%016llx", stats.nServices)));

laanwj commented at 3:41 PM on June 21, 2014:

Nit: please leave out the size specifier (ll) - tinyformat doesn't care about it.

laanwj commented at 3:41 PM on June 21, 2014: member

ACK apart from nit

Add nLocalServices info to RPC getinfo

Also show full 64 bits of services. Previously service bits >32 that
were advertised just didn't show up at all.

99ddc6cb70

Add comment regarding experimental-use service bits
As per mailing list discussion.
38405ac141
petertodd commented at 3:50 PM on June 21, 2014: contributor

@laanwj Fixed tinyformat nit.
sipa commented at 3:57 PM on June 21, 2014: member

ACK
jgarzik commented at 3:58 PM on June 21, 2014: contributor

ACK
BitcoinPullTester commented at 5:08 PM on June 21, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/38405ac1411ce73f6945f296980d559e2949027f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
ghost commented at 5:11 PM on June 21, 2014: none

ACK
laanwj merged this on Jun 21, 2014
laanwj closed this on Jun 21, 2014
laanwj referenced this in commit 540ce6aa10 on Jun 21, 2014
jgarzik commented at 5:27 PM on June 21, 2014: contributor

This wants a tiny BIP, IMO, noting the service bit experimental range.
laanwj commented at 6:38 PM on June 21, 2014: member

Agreed. Though that BIP could be very short and simple. Basically just the contents of that comment.
petertodd deleted the branch on Jun 21, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors