Allocate receive buffers in on the fly #4381

1. 
   sipa commented at 3:00 pm on June 21, 2014: member
2. Allocate receive buffers in on the fly 806fd19ecb
3. 
   sipa commented at 3:19 pm on June 21, 2014: member

   Right, in non-attack scenarios, we never over-allocate (not before and not after this patch). All it does is limit the overallocation by a non-sending stalling attacker to 256 KiB per connection.
4. 
   jgarzik commented at 3:19 pm on June 21, 2014: contributor

   ACK. comment deleted. Need my morning caffeine.
5. 
   laanwj commented at 3:32 pm on June 21, 2014: member

   If there would have been no hint in the protocol as to how much data to expect, the strategy to first allocate a small buffer would make a lot of sense.

   tested ACK

6. 
   BitcoinPullTester commented at 4:52 pm on June 21, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/806fd19ecba0d58bf238a7b6f78e080da03eb9c7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
7. sipa merged this on Jun 22, 2014
8. sipa closed this on Jun 22, 2014

   ---

9. sipa referenced this in commit 6b40eabbcf on Jun 22, 2014
10. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa jgarzik laanwj BitcoinPullTester