incremental net cleanup 1 #4388

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:net_cleanup_incr_1 changing 2 files +1 −7

Diapolo commented at 12:57 PM on June 22, 2014: none

I'm going to split of some changes from #4348 to make review easier and hopefully merging faster :).
remove unused CNode::Cleanup() 2831a03b79
add missing vhListenSocket.clear(); to CNetCleanup() 3dc1464f0a
BitcoinPullTester commented at 3:03 PM on June 22, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3dc1464f0a87e26f3aa39c446eb4d102a8c84dc2 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 3:23 PM on June 22, 2014: member

ACK.

The second commit isn't necessary: there is no allocation associated with vhListenSocket. It can't hurt though.
Diapolo renamed this:
~~incremental net cleanup~~
incremental net cleanup 1
on Jun 22, 2014
laanwj merged this on Jun 23, 2014
laanwj closed this on Jun 23, 2014
laanwj referenced this in commit 52d4abfdef on Jun 23, 2014
laanwj commented at 8:21 AM on June 23, 2014: member

Good idea to split this up.
Diapolo deleted the branch on Jun 23, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors