This avoids a race condition in which the connection was made but the version handshake is not completed yet. In that case transactions won't be broadcasted to a peer yet, and the nodes will wait forever for their mempools to sync.
qa/rpc_tests: Wait for handshake to complete in connect_nodes #4394
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_06_rpc_tests_connectnode changing 1 files +4 −0-
laanwj commented at 3:44 PM on June 23, 2014: member
-
3b1295e988
qa/rpc_tests: Wait for handshake to complete in connect_nodes
This avoids a race condition in which the connection was made but the version handshake is not completed yet. In that case transactions won't be broadcasted to a peer yet, and the nodes will wait forever for their mempools to sync.
-
gavinandresen commented at 3:54 PM on June 23, 2014: contributor
Nice!
- gavinandresen referenced this in commit 6d875669aa on Jun 23, 2014
- gavinandresen merged this on Jun 23, 2014
- gavinandresen closed this on Jun 23, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors