Remove timing-based signature cache unit test #4414

Two changes:

First removes a unit test that fails in my development environment (OSX, compiled -g3 with clang).

sipa says that's not terribly surprising; the CMutableTransaction change makes signing a little more expensive but verification quicker. The unit test timed sign+verify-uncached versus verify-cached-five-times.

He also says the test will be invalid when libsec256kp1 is integrated (because validation is super-optimized over signing).

core.h change fixes a compiler warning (clang -Wall : CMutableTransaction defined as struct, declared as class in script.h).

CMutableTransaction is a struct in both places. You're changing one of them into class...

Bah, changed the wrong declaration, will fix:

script.h:class CMutableTransaction;

ACK

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4414_a90689ff9880cc76668d04beda5a5d97f2f4a76b/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

I suppose the actual signing/validation is already tested elsewhere? Otherwise it may make sense to remove the timing-dependent checks and keep the verify ones.

Yes, there are several sign/verification tests in key_tests.cpp, and indirectly anything doing transaction or block validation testing as well.

Ok, ACK