fix copyright string in two of our *.rc files #4429

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:rc_version changing 3 files +3 −3

Diapolo commented at 12:53 PM on June 27, 2014: none
- also make comment about rc-files in clientversion.h generic

fix copyright string in two of our *.rc files

- also make comment about rc-files in clientversion.h generic

05b05562d1

in src/version.cpp:None in 9f0e1232ea outdated
```
   6 | @@ -7,13 +7,12 @@
   7 |  #include <string>
   8 |  
   9 |  // Name of client reported in the 'version' message. Report the same name
  10 | -// for both bitcoind and bitcoin-qt, to make it harder for attackers to
  11 | +// for both bitcoind and Bitcoin Core, to make it harder for attackers to
```
laanwj commented at 6:30 AM on June 29, 2014:

this is talking about the names of the executables, which are still bitcoind and bitcoin-qt

Diapolo commented at 6:02 AM on June 30, 2014:

Should bitcoin-cli be mentioned?

laanwj commented at 6:16 AM on June 30, 2014:

No - it doesn't connect to the bitcoin network.

Diapolo commented at 1:20 PM on June 30, 2014:

Removed that commit!

in src/bitcoind-res.rc:None in 9f0e1232ea outdated

   4 | @@ -5,7 +5,7 @@
   5 |  #define VER_PRODUCTVERSION_STR STRINGIZE(CLIENT_VERSION_MAJOR) "." STRINGIZE(CLIENT_VERSION_MINOR) "." STRINGIZE(CLIENT_VERSION_REVISION) "." STRINGIZE(CLIENT_VERSION_BUILD)
   6 |  #define VER_FILEVERSION        VER_PRODUCTVERSION
   7 |  #define VER_FILEVERSION_STR    VER_PRODUCTVERSION_STR
   8 | -#define COPYRIGHT_STR          "2009-" STRINGIZE(COPYRIGHT_YEAR) " The Bitcoin Core developers"
   9 | +#define COPYRIGHT_STR          "2009-" STRINGIZE(COPYRIGHT_YEAR) " The Bitcoin Core Developers"

laanwj commented at 6:34 AM on June 29, 2014:

Would it be possible to put this #define in one place instead, for example clientversion.h?

Diapolo commented at 6:03 AM on June 30, 2014:

Didn't try, just saw that we recently had a fix for this for one file and use three.

BitcoinPullTester commented at 1:39 PM on June 30, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4429_05b05562d18501f35030a5b9aec56fe626e3118b/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 8d9cc7d743 on Jul 1, 2014
laanwj commented at 10:14 AM on July 1, 2014: member

Merged via 8d9cc7d
laanwj closed this on Jul 1, 2014
Diapolo deleted the branch on Jul 1, 2014
MathyV referenced this in commit fd64cfc3f0 on Nov 3, 2014
reddink referenced this in commit 1ff2b5c149 on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester