Change Bitcoin-Qt to bitcoin core #4438

No description provided.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4438_c5966ae089cb4b24c1f35b7feed90c0d591353e2/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

What will be the effect here to existing users? Does this need backwards compatibility code? (for example, if it changes some settings location... I don't know what this identifier is used for)

@laanwj Perhaps we should onetime break the old naming (also the app name in guiconstans.h), which also will reset all settings, yes... but at that time we could also cleanup current naming of settings values etc. ... not sure if we should take the time to write some backward compatibility code for this but perhaps just warn in the changelog one or two releases earlier?

@Diapolo Maybe at some point in the future, when we've run out of bugs to solve and important features to add.

@laanwj I found "just" this: https://developer.apple.com/library/mac/qa/qa1373/_index.html

@theuni Do you perhaps know if this change is harmless?

Closing this. I discussed with @theuni and the risk was to high for apparantly no gain. It could, for example, break specific firewall rules.