Use GetBlockTime() more #4446

1. 
   jtimon commented at 9:36 pm on June 30, 2014: contributor

   int64_t is preferred over unsigned int for time calculations when possible.
2. 
   sipa commented at 10:11 pm on June 30, 2014: member

   Untested ACK
3. 
   laanwj commented at 1:44 pm on July 1, 2014: member

   I’ve reviewed the code and found no problems. Nice to get rid of a cast here and there in the RPC code.
4. 
   jgarzik commented at 3:30 pm on July 1, 2014: contributor

   untested ACK
5. 
   BitcoinPullTester commented at 11:45 am on July 5, 2014: none

   Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4446_56d53b2a920f40caacc40d0bf45396c68584c526/ for binaries and test log.

   This could happen for one of several reasons:

   1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
   2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
   3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
   4. The test suite fails on either Linux i386 or Win32
   5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

   If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

   This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

6. Use GetBlockTime() more 209377a7cb
7. 
   laanwj commented at 8:28 am on July 7, 2014: member

   Tested ACK
8. laanwj merged this on Jul 7, 2014
9. laanwj closed this on Jul 7, 2014

   ---

10. laanwj referenced this in commit 4851d09603 on Jul 7, 2014
11. jtimon deleted the branch on Jul 7, 2014
12. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon sipa laanwj jgarzik BitcoinPullTester