No need for such accuracy (and reduces readability of debug.log) #4452

Revert to previous behaviour. This way the ++nLastTime number can be viewed within debug.log. If the GetTimeMicros() is kept, then there is no need to display the number (not converted to a time) since this provides no useful information any longer.

This affects more than the debug.log. Please change the logging instead.

@laanwj ah, yes, that might make more sense. Will do.

@laanwj Actually the whole thing with nLastTime isn't needed any more is it? This was only needed when nNow was recorded in seconds, but now that it's milliseconds, it's very unlikely there'll be two nNows that are equal. Also, the -1 was added when it was seconds since 1 was the small subtraction possible. Why, when it changes to milliseconds, was the 1 changed to 1000000? 1 is still the smallest subtraction possible, so surely it should be -1 not -1000000. Or am I misunderstanding the point of the code? @sipa ?

What the code that you removed does is make sure that timestamps are monotonically increasing. NACK on removing it.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4452_c8f1cf56d4d76c75f75f06eef54c8a521807795e/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Closing this - if you want to change logging, just change logging.