Move ui_interface to bitcoin_server #4459

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2014_07_dont_translate_unneeded changing 7 files +55 −41

laanwj commented at 5:55 AM on July 3, 2014: member

There is no need for it in the utility libraries or tools. Put it in init.cpp (in bitcoin_server.a).

Also parse translation messages only from appropriate files by making extract_strings_qt.py specific, which saves translators some unnecessary work translating messages from bitcoin-cli.
laanwj referenced this in commit e413f94f2e on Jul 7, 2014

qt: Pick translation messages only from necessary files

Utility libraries (common, util) as well as extra tools shouldn't be
parsed for translation messages, only the server and wallet part qualify
here.

509030344c

Move ui_interface to bitcoin_server.a

There is no need for it in the utility libraries or tools.
Put it in init.cpp, and in the tests separately (as they can't link init).

73ac7abd08

laanwj merged this on Jul 7, 2014
laanwj closed this on Jul 7, 2014
laanwj referenced this in commit 6fa1f794f7 on Jul 7, 2014
BitcoinPullTester commented at 8:39 AM on July 7, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4459_73ac7abd08a70adf22e24d0f5f7631e7f8b7c5bb/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
MarcoFalke locked this on Sep 8, 2021

Contributors