In the following piece of code in "main.cpp", chainActive.Genesis() could return NULL, there's no branch doing this case. If chainActive.Genesis() returns NULL, the code will crash
vStack.push_back(make_pair(0, chainActive.Genesis()));
int nPrevCol = 0;
int count = 0;
while (!vStack.empty())
{
cout << count++ << endl;
int nCol = vStack.back().first;
CBlockIndex* pindex = vStack.back().second;
vStack.pop_back();
Hmm, why do you think it will crash? Just out of curiosity, I have replaced the call to Genesis() with NULL and it didn't crash here... ... time passes ... Hmm yes, it crashes here (you have to compile the file after change 8)). But this can't happen because we initialize genesis inside
bool InitBlockIndex() {
So even you run that particular code without the blocks, ./bitcoind -printblocktree -testnet -debug -printtoconsole prints:
...
init message: Verifying blocks...
block index 608ms
0 (blk00000.dat:0x8) 2011-02-02 23:16:42 tx 1
...
ie. it doesn't fail - because the Genesis block is added.
The code got removed as part of #5385. This issue can be closed now.
Hah. Deleting code is the best way to get rid of bugs.