Bugfix: send rejects and apply DoS scoring for errors in direct block validation. #4471

pull sipa wants to merge 1 commits into bitcoin:master from sipa:fixreject changing 1 files +10 −0

sipa commented at 12:53 PM on July 6, 2014: member

#3370 introduced asynchronous processing for blocks, where reject messages and DoS scoring could be applied outside of ProcessBlock, because block validation may happen later.

However, some types of errors are still detected immediately (in particular, CheckBlock violations), which need acting after ProcessBlock returns.

Send rejects and apply DoS scoring for errors in direct block validation.

75f51f2a introduced asynchronous processing for blocks, where reject messages
and DoS scoring could be applied outside of ProcessBlock, because block
validation may happen later.

However, some types of errors are still detected immediately (in particular,
CheckBlock violations), which need acting after ProcessBlock returns.

40f5cb878e

BitcoinPullTester commented at 1:50 PM on July 6, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4471_40f5cb878edd04b4be14f0d73ab706dc2e69124c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 7:17 AM on July 7, 2014: member

ACK on code review
gavinandresen commented at 3:17 PM on July 7, 2014: contributor

ACK
laanwj merged this on Jul 7, 2014
laanwj closed this on Jul 7, 2014
laanwj referenced this in commit c6ac5fcfc2 on Jul 7, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3370 Prepare block connection logic for headers-first