test/bloom_tests: Use UL suffix for unsigned long number to ensure compatibility #4480

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bloomtest_ul changing 1 files +1 −1

luke-jr commented at 3:43 PM on July 7, 2014: member

Silences a GCC warning because we don't explicitly build for C++11 (yet?).
test/bloom_tests: Use UL suffix for unsigned long number to ensure compatibility 2227725fcb
gavinandresen commented at 3:52 PM on July 7, 2014: contributor

ACK. If pull-tester is happy, I'm happy.
laanwj merged this on Jul 7, 2014
laanwj closed this on Jul 7, 2014
laanwj referenced this in commit 1fedd65fcf on Jul 7, 2014
laanwj commented at 4:46 PM on July 7, 2014: member
Thanks, this warning also annoyed me every time, but I was unsure how to fix it. I mean the signature of CBloomFilter is:
```
CBloomFilter::CBloomFilter(unsigned int nElements, double nFPRate, unsigned int nTweakIn, unsigned char nFlagsIn) 
```
The large number is passed as nTweakIn. It'll not fit in an unsigned int, at least on platforms on which the int is 32 bits (most of them).

Anyhow this fix is OK. The compiler will just slice the value to the lower bits, as before.
BitcoinPullTester commented at 5:00 PM on July 7, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4480_2227725fcb68cf70bc3b33e68d4288df6c4a219a/ for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
luke-jr commented at 5:15 PM on July 7, 2014: member

I don't see anything in the log indicating failure :/
laanwj commented at 7:31 AM on July 8, 2014: member

@luke-jr that was a fluke. This test-only change cannot have an effect on the listtransactions RPC test.
luke-jr deleted the branch on Jan 1, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors