Use unordered_map for CCoinsViewCache with salted hash #4494

1. 
   sipa commented at 3:26 pm on July 9, 2014: member

   Modified version of #4413 which uses salted lookup3 for computing txid hash keys.
2. sipa renamed this:
   Add use salted hash unordered_map for CCoinsViewCache
   Use unordered_map for CCoinsViewCache with salted hash
   on Jul 9, 2014
3. 
   laanwj commented at 4:29 pm on July 9, 2014: member

   ACK on code changes, going to test.

   BTW, neat solution, didn’t realize it could be done like this without introducing (overt) global state.

4. in src/coins.cpp: in 7872189a7e outdated

   3@@ -4,6 +4,8 @@
   4 
   5 #include "coins.h"
   6 
   7+#include "util.h"
   

   ---

   ---

   

   laanwj commented at 11:21 am on July 14, 2014:

   This should be random.h after #4400
5. 
   jgarzik commented at 1:19 pm on July 14, 2014: contributor

   Basic question… does this build on all platforms? In another project. I cannot use unordered_set because it is a too-recent addition.

   We must confirm that unordered_map lacks the same issues, as it is the first use in the tree.

6. 
   sipa commented at 2:02 pm on July 14, 2014: member

   @jgarzik std::unordered_map is recent c++. boost::unordered_map is just boost.
7. Use unordered_map for CCoinsViewCache with salted hash bc42503f6a
8. 
   sipa commented at 2:13 pm on July 14, 2014: member

   Rebased.
9. 
   laanwj commented at 2:31 pm on July 14, 2014: member

   It gets through the pulltester, it doesn’t get any older than that :)
10. 
    BitcoinPullTester commented at 2:46 pm on July 14, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4494_bc42503f6ab304608c321986a870795e45f5a016/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
11. laanwj merged this on Jul 15, 2014
12. laanwj closed this on Jul 15, 2014

    ---

13. laanwj referenced this in commit 1f5e8fe804 on Jul 15, 2014
14. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa laanwj jgarzik BitcoinPullTester