Bugfix: only remove actualy failed blocks from setBlockIndexValid #4496

1. 
   sipa commented at 3:44 pm on July 9, 2014: member

   Fix an unexposed bug in dealing with invalid blocks: only chains with actually invalid blocks should be removed from the set of potentially new tips.

   Also, in case an error is found, the failed block itself must be removed from that set.

   This would be exposed by #4468.

2. Only remove actualy failed blocks from setBlockIndexValid 5734d4d1e6
3. 
   sipa commented at 4:31 pm on July 9, 2014: member

   Oops, stale negation. Fixed.
4. 
   BitcoinPullTester commented at 6:13 pm on July 9, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4496_5734d4d1e6ee89361fc2484f5d33315397796c0d/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. 
   laanwj commented at 4:17 pm on July 23, 2014: member

   Tested ACK
6. laanwj merged this on Jul 24, 2014
7. laanwj closed this on Jul 24, 2014

   ---

8. laanwj referenced this in commit 70d0325999 on Jul 24, 2014
9. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa BitcoinPullTester laanwj