Optimization: only keep setBlockIndexValid entries that are possible improvements #4497

1. 
   sipa commented at 4:06 pm on July 9, 2014: member

   Before, we kept all valid CBlockIndex* entries in setBlockInvalidValid, but as it is only used to select potential new tips to activate, it suffices to only keep entries that are at least as good as the current tip.

   This should save some memory in the stable synced state: 13 MiB on 64 bit, 8 MiB on 32 bit.

2. 
   sipa commented at 7:16 pm on July 9, 2014: member

   Thanks @BitcoinPullTester, fixed a bug.
3. Only keep setBlockIndexValid entries that are possible improvements 714a3e6505
4. 
   sipa commented at 2:01 pm on July 11, 2014: member

   Added some comments and an assert.
5. 
   BitcoinPullTester commented at 2:24 pm on July 11, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4497_714a3e6505d986d064d3a34038a724ac1cad5308/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
6. 
   laanwj commented at 4:18 pm on July 23, 2014: member

   Tested ACK (ran on test node for two weeks without problems)
7. 
   jgarzik commented at 4:53 pm on July 29, 2014: contributor

   ut ACK
8. sipa merged this on Jul 30, 2014
9. sipa closed this on Jul 30, 2014

   ---

10. sipa referenced this in commit e8cb5c30b0 on Jul 30, 2014
11. sipa deleted the branch on Jul 30, 2014
12. MarcoFalke locked this on Sep 8, 2021

Contributors
sipa BitcoinPullTester laanwj jgarzik