Convert closesocket 'compat wrapper' to function in netbase #4504

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_07_closesocket changing 5 files +45 −47

laanwj commented at 10:18 AM on July 10, 2014: member

Simpler alternative to #4348.

The current setup with closesocket() is strange. It poses as a compatibility wrapper but adds functionality.

Rename it and make it a documented utility function CloseSocket in netbase.

Code movement only, zero effect on functionality.
sipa commented at 1:22 PM on July 10, 2014: member

Untested ACK

Convert closesocket 'compat wrapper' to function in netbase

Simpler alternative to #4348.

The current setup with closesocket() is strange. It poses
as a compatibility wrapper but adds functionality.

Rename it and make it a documented utility function in netbase.

Code movement only, zero effect on the functionality.

43f510d37d

laanwj merged this on Jul 17, 2014
laanwj closed this on Jul 17, 2014
laanwj referenced this in commit e8d4cb8071 on Jul 17, 2014
BitcoinPullTester commented at 2:43 PM on July 17, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4504_43f510d37d680ca4347878d2fb6f8b97b54e7611/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo commented at 3:19 PM on July 17, 2014: none

I'm not happy with this, as I said it's IMHO no real alternative, but seems to me like pure refactoring.
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4348 SOCKET changes (CSocket RAII etc.)