#4450 introduced a check for non-equivalent double spends and relaying, but for equivalent double spends it changed existing behaviour by still calling mempool.addUnchecked() on them. This breaks mempool consistency (detected using -checkmempool after a few days of running), which could be exploited to crash miner's nodes.
Do not overwrite mempool transactions with equivalent double-spends #4514
pull sipa wants to merge 1 commits into bitcoin:master from sipa:fixrelaypool changing 1 files +5 −4-
sipa commented at 3:23 PM on July 12, 2014: member
-
Do not overwrite mempool transactions with equivalent double-spends b7cae362ce
-
-
BitcoinPullTester commented at 4:08 PM on July 12, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4514_b7cae362ce1f12a1092d5b543840cef9e1580c20/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
-
- sipa closed this on Jul 12, 2014
- MarcoFalke locked this on Sep 8, 2021
Contributors