[Qt] Fix segfault when launched with -disablewallet #4518

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz7 changing 3 files +33 −9

cozz commented at 5:55 AM on July 13, 2014: contributor

An early MessageBox triggers showNormalIfMinimized() which triggers the show-events in rpcconsole in disablewallet-mode causing segfaults when clientModel is not set.

Unrelated change, but I noticed the unitDisplay icon is shown in disablewallet-mode, doesnt make sense for now.

Fixes #4516
[Qt] Fix segfault when launched with -disablewallet 76fd7b8c26
BitcoinPullTester commented at 6:25 AM on July 13, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4518_76fd7b8c2677dc145a67e86153d629b43d2a92e5/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
ghost commented at 8:19 AM on July 13, 2014: none

ACK
rdponticelli commented at 2:56 PM on July 13, 2014: contributor

ACK
laanwj commented at 6:12 AM on July 14, 2014: member

Yes this is a problem. In the past I've added the NOSHOWGUI flag to messages to avoid the showNormalIfMinimized() from being called, but I don't think this is the correct solution anymore (as we don't always know in what context messages are produced).

Probably we should ignore showNormalIfMinimized if the client model is NULL. There is no use in showing the GUI windows if we don't have an initialized client.

ACK, +1 on adding NULL pointer checks.
laanwj commented at 8:49 AM on July 14, 2014: member

See also #4524.
laanwj merged this on Jul 14, 2014
laanwj closed this on Jul 14, 2014
laanwj referenced this in commit b5280c31db on Jul 14, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#4516 Segfault in bitcoin-qt when launched with -disablewallet #4524 qt: Ignore showNormalIfMinimized in initialization or shutdown