The regtest framework is local, so don't try to discover our external IP. This should keep those writing regtests from spending time debugging to #4502.
I suspect this also caused the pulltester hang mentioned in #4485.
3rd party IP providers seem to be interpreting node stop/start activity, common in regtests, to be DoS, making shutdown problems more common that one might otherwise expect.
The regtest framework is local, so often there is no need to
discover our external IP. Setting -discover=0 in util.py works
around shutdown hang caused by GetExternalIP waiting in recv().
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4522_cdf305eeb042eb67c5e53a8b04cf475578b0f8e8/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Should be solve this in Init in bitcoind itself? Ie, default discover to 0 if -regtest set?
The framework explicitly creates nodes interconnecting to 127.0.0.1 so it seems at least more likely to be right there.
Please, no more magic behavior triggered by -regtest.
Ping @gavinandresen @theuni
ACK.