Fix for error in ‘getbalance’ when using watchonly addresses/scripts. #4525

1. 
   tuttleorbuttle commented at 9:47 am on July 14, 2014: none

   This bug can result in too much watchonly balance being returned by the getbalance RPC call.
2. tuttleorbuttle renamed this:
   Fix for error in 'getbalance' when using watchonly addresses.
   Fix for error in 'getbalance' when using watchonly addresses/scripts.
   on Jul 14, 2014
3. in src/rpcdump.cpp: in db87e53b5c outdated

   137@@ -138,7 +138,8 @@ Value importaddress(const Array& params, bool fHelp)
   138     if (fHelp || params.size() < 1 || params.size() > 3)
   139         throw runtime_error(
   140             "importaddress <address> [label] [rescan=true]\n"
   141-            "Adds an address or script (in hex) that can be watched as if it were in your wallet but cannot be used to spend.");
   142+            "Adds an address or script (in hex) that can be watched as if it were in your wallet but cannot be used to spend.\n"
   143+            "This is experimental, unknown glitches may cause erroneous balances to be returned. Use with caution, back up your wallet.");
   

   ---

   ---

   

   laanwj commented at 10:03 am on July 14, 2014:

   Do we need this extra warning in addition to the This is a pre-release test build - use at your own risk - do not use for mining or merchant applications that already comes in pre-release builds by default?

   ---

   

   tuttleorbuttle commented at 10:40 am on July 14, 2014:

   Depends on how much this feature is going to be tested before 0.10.0 I suppose. Shall I remove it?

   ---

   

   unknown commented at 10:48 am on July 14, 2014:

   Remove it.

   ---

   

   laanwj commented at 10:56 am on July 14, 2014:

   Yeah, I think it’s unnecessary. There are many things in 0.10 master that would require warnings otherwise :)
4. 
   ghost commented at 10:48 am on July 14, 2014: none

   Other than nit: ACK
5. Fixed error in 'getbalance' when using watchonly addresses. d512534cd7
6. 
   tuttleorbuttle commented at 11:03 am on July 14, 2014: none

   done :)
7. laanwj merged this on Jul 14, 2014
8. laanwj closed this on Jul 14, 2014

   ---

9. laanwj referenced this in commit d5a6b785e3 on Jul 14, 2014
10. 
    BitcoinPullTester commented at 11:29 am on July 14, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4525_d512534cd71ebdb67bf0cb2a377dc7c2b06ba438/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
11. wtogami referenced this in commit 80a894544c on Sep 9, 2014
12. wtogami referenced this in commit a80a879135 on Sep 10, 2014
13. wtogami referenced this in commit dff7569e75 on Sep 19, 2014
14. wtogami referenced this in commit a271524739 on Oct 2, 2014
15. wtogami referenced this in commit 16f84e07c6 on Nov 14, 2014
16. wtogami referenced this in commit 5da988e9ea on Dec 23, 2014
17. MarcoFalke locked this on Sep 8, 2021

Contributors
tuttleorbuttle laanwj ghost BitcoinPullTester