After #4400 util does not need to depend on uint256 anymore, so it can move up.
Move uint256.cpp from util to common lib #4527
pull sipa wants to merge 1 commits into bitcoin:master from sipa:moveuint changing 3 files +1 −4-
sipa commented at 2:35 PM on July 14, 2014: member
-
Move uint256.cpp from util to common lib 5b3b037ee1
-
laanwj commented at 2:39 PM on July 14, 2014: member
But we still have random.cpp in util which depends on uint256 AFAIK (RandHash).
-
sipa commented at 3:08 PM on July 14, 2014: member
Ugh, right.
So, we could move random to common as well, except that util still does the openssl locking/randomness initialization (which depends on random). That seems unnecessary, as util itself does not require any openssl apart from that.
Either we can move the crypto locking initialization to random too (but that broadens its scope), make a small seperate file that does all remaining OpenSSL wrapping, or just wait until we can drop OpenSSL entirely.
-
laanwj commented at 3:23 PM on July 14, 2014: member
bitcoin-cli can use SSL, so we do require the OpenSSL initialization in util.cpp for now.
Moving random.cpp to common as well sounds good. Could the random initialization be split from the main OpenSSL initialization? I suppose we'll have initialization order issues as long as we use the current, hacky, global constructor method.
-
sipa commented at 3:27 PM on July 14, 2014: member
Yup, initialization order is the problem. These things will need to turn into boost::once initialized structures etc.
-
BitcoinPullTester commented at 3:48 PM on July 14, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4527_5b3b037ee1f06446db8252b2d14eb60ca9fe8837/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
sipa commented at 2:13 PM on July 15, 2014: member
Closing for now.
- sipa closed this on Jul 15, 2014
- MarcoFalke locked this on Sep 8, 2021