Make the message a little friendlier #4528

pull whitj00 wants to merge 2 commits into bitcoin:master from whitj00:patch-4 changing 1 files +1 −1

whitj00 commented at 6:22 PM on July 14, 2014: contributor

No description provided.
Make the message a little friendlier 4588142e4a
Update addressbookpage.cpp b42430d347

in src/qt/addressbookpage.cpp:None in 4588142e4a outdated

 281 | @@ -282,7 +282,7 @@ void AddressBookPage::on_exportButton_clicked()
 282 |  
 283 |      if(!writer.write()) {
 284 |          QMessageBox::critical(this, tr("Exporting Failed"),
 285 | -            tr("There was an error trying to save the address list to %1.").arg(filename));
 286 | +            tr("There was an error trying to save the address list to %1.  Please try again.").arg(filename));

laanwj commented at 6:26 AM on July 15, 2014:

Please add a single space instead of a double space.

whitj00 commented at 11:02 PM on July 15, 2014: contributor

@laanwj fixed :)
BitcoinPullTester commented at 11:29 PM on July 15, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4528_b42430d347038c6f5761e151eddb878278f495da/ for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 2:08 PM on July 17, 2014: member

It depends a lot on the kind of error, but I'm not sure 'Try again' is usually good advice. (well obviously he needs to try again, but probably after changing something else first)
whitj00 commented at 7:11 PM on July 17, 2014: contributor

I am in favor because there are a ton of things that could have caused it, and if we want people like my dad (who just bought his first btc) to use a safe wallet instead of online wallets, we should give them something other than "somethings wrong, go fix it cuz you know how to right mmkkay"

Often retrying can fix things, and if people try again and it still doesn't work, then it's kind of clear that they need to alter something
laanwj merged this on Jul 18, 2014
laanwj closed this on Jul 18, 2014
laanwj referenced this in commit d5a4ed372a on Jul 18, 2014
laanwj referenced this in commit b9345f7d1c on Jul 18, 2014
whitj00 deleted the branch on Jul 26, 2014
MathyV referenced this in commit 0c274a3623 on Nov 24, 2014
reddink referenced this in commit 8d35170d5a on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

whitj00

laanwj

BitcoinPullTester