[Qt] Prevent balloon-spam after rescan #4530

cozz commented at 7:42 PM on July 14, 2014: contributor

importaddress mrhz5ZgSF3C1BSdyCKt3gEdhKoRL5BNfJV adds like 2500 transactions to the wallet, this caused my desktop-panel to freeze, because of the balloon spam, so show maximum of 100 balloons after rescan.

in src/qt/walletmodel.h:None in d05dabf5fd outdated

 132 | @@ -133,6 +133,7 @@ class WalletModel : public QObject
 133 |      qint64 getWatchImmatureBalance() const;
 134 |      int getNumTransactions() const;
 135 |      EncryptionStatus getEncryptionStatus() const;
 136 | +    bool showNotifications() { return fNotifications; }

laanwj commented at 6:21 AM on July 15, 2014:

I'd suggest to make this name more descriptive of what is happening, instead of how the view should react to it. For example, processingQueuedTransactions().

cozz commented at 1:21 PM on July 15, 2014: contributor

update:

renamed to ProcessingQueuedTransactions

laanwj commented at 2:50 PM on July 15, 2014: member

Untested ACK

Diapolo commented at 3:47 PM on July 15, 2014: none

@cozz Any idea for #4272? Did you also observe this?

cozz commented at 10:49 PM on July 15, 2014: contributor

@Diapolo I never ran into that problem, probably because I normally do not use windows. I just did some quick tests, could not reproduce the bug.

[Qt] Prevent balloon-spam after rescan acd432b5b3

in src/qt/walletmodel.cpp:None in 18d65603e4 outdated

 493 | @@ -492,8 +494,15 @@ static void ShowProgress(WalletModel *walletmodel, const std::string &title, int
 494 |      if (nProgress == 100)
 495 |      {
 496 |          fQueueNotifications = false;
 497 | -        BOOST_FOREACH(const PAIRTYPE(uint256, ChangeType)& notification, vQueueNotifications)
 498 | -            NotifyTransactionChanged(walletmodel, NULL, notification.first, notification.second);
 499 | +        if (vQueueNotifications.size() > 100) // prevent balloon spam, show maximum 100 balloons

laanwj commented at 10:23 AM on July 17, 2014:

I'd say lower this to 10. 10 balloons at once is already a crazy party.

cozz commented at 1:40 AM on July 18, 2014:

ok, changed to 10 balloons

BitcoinPullTester commented at 2:17 AM on July 18, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4530_acd432b5b38464ef3ecb87f80b1bbebe9d7c2022/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

laanwj merged this on Jul 18, 2014

laanwj closed this on Jul 18, 2014

laanwj referenced this in commit ba738634ae on Jul 18, 2014

wtogami referenced this in commit 010c76124d on Sep 9, 2014

wtogami referenced this in commit af8d450131 on Sep 10, 2014

wtogami referenced this in commit e715e316d2 on Sep 19, 2014

wtogami referenced this in commit 8bfa723718 on Oct 2, 2014

wtogami referenced this in commit 06d9bc4b7e on Nov 14, 2014

wtogami referenced this in commit 13aa48b438 on Dec 23, 2014

MarcoFalke locked this on Sep 8, 2021