... bitcoin instead of satoshis
- Fix bug in prioritisetransaction: add to vRPCConvertParams
- Fixes #4419
Add helptexts for -whitelist and rpc prioritisetransaction and switch to... #4531
pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz5 changing 3 files +24 −2-
cozz commented at 12:42 AM on July 15, 2014: contributor
-
Add helptexts for -whitelist and rpc prioritisetransaction and switch to bitcoin instead of satoshis ebdcc360b6
-
BitcoinPullTester commented at 4:13 AM on July 15, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4531_ebdcc360b65816f7ad7cdedce6a1114d5e014b7b/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 6:11 AM on July 15, 2014: member
Taking bitcoin instead of satoshi is more uniform to our current RPC interface. I do think it's a bit late to make this change now that it's already merged, people may be depending on the current interface. If satoshi are passed and get interpreted as BTC it may result in some terrible confusion.
-
-
Michagogo commented at 3:59 PM on July 15, 2014: contributor
@laanwj Meh, I don't think getting committed to master should be considered definitive. It hasn't been in a release yet. Git master isn't presented as something that can be relied on to remain stable or even be very safe to use. Anyone using non-release builds (well, anyone, considering what software we're talking about, but especially if you're not using releases) is being irresponsible if they pull in changes and run them without looking at them or knowing what's happening. This hasn't been in a release yet, I don't see a problem changing this. The same could be said for changing the null-smalldata txout type from 80 to 40 bytes. Not to mention, it's unlikely that there will be numbers that can be shifted by 8 decimal places and still make sense...
-
laanwj commented at 9:32 AM on July 18, 2014: member
@Michagogo Agreed.
-
laanwj commented at 9:54 AM on July 18, 2014: member
Untested ACK
-
sipa commented at 8:11 PM on July 18, 2014: member
Untested ACK
- laanwj merged this on Jul 28, 2014
- laanwj closed this on Jul 28, 2014
- laanwj referenced this in commit aaa7076937 on Jul 28, 2014
-
luke-jr commented at 12:33 PM on December 1, 2014: member
Hm, I completely missed this. prioritisetransaction has been around and used since about v0.6.0, so I'm not sure we should change the interface this late... Anyone who ACK'd the change here want to reconsider given that it "It hasn't been in a release yet." is NOT quite accurate?
- MarcoFalke locked this on Sep 8, 2021
